Project

General

Profile

Actions

Bug #8768

closed

[PATCH] tempfile: undefine finalizer on unlink

Added by normalperson (Eric Wong) over 10 years ago. Updated over 10 years ago.

Status:
Closed
Target version:
ruby -v:
ruby 2.1.0dev (2013-08-10 trunk 42491) [x86_64-linux]
[ruby-core:56521]

Description

  • lib/tempfile.rb (Tempfile#unlink): undefine finalizer

running the finalizer on an unlinked Tempfile leads to a confusing
"removing ...done" message when using --debug. We can rely on
normal GC to close. rb_io_fptr_finalize will take care of closing
the descriptor without the extra finalizer for Tempfile.


Files

0001-lib-tempfile.rb-Tempfile-unlink-undefine-finalizer.patch (1.84 KB) 0001-lib-tempfile.rb-Tempfile-unlink-undefine-finalizer.patch patch incuding testcase normalperson (Eric Wong), 08/11/2013 04:41 AM
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0