Bug #9048

Remove legacy ±(binary) special cases.

Added by Marc-Andre Lafortune 6 months ago. Updated 6 months ago.

[ruby-core:57995]
Status:Closed
Priority:Low
Assignee:Marc-Andre Lafortune
Category:core
Target version:-
ruby -v:- Backport:1.9.3: DONE, 2.0.0: DONE

Description

Is there any reason not to get rid of the following special cases?

'+(binary)'.to_sym # => :+ when expected :"+(binary)"

The following patch didn't reveal any failure in make test:

diff --git a/parse.y b/parse.y
index 76fc9e7..6550235 100644
--- a/parse.y
+++ b/parse.y
@@ -10045,8 +10045,6 @@ static const struct {
} optbl[] = {
{tDOT2, ".."},
{tDOT3, "..."},
- {'+', "+(binary)"},
- {'-', "-(binary)"},
{tPOW, ""},
{tDSTAR, "
"},
{tUPLUS, "+@"},
diff --git a/test/ruby/test
m17n.rb b/test/ruby/testm17n.rb
index 7c37c8a..3ea346f 100644
--- a/test/ruby/test
m17n.rb
+++ b/test/ruby/test_m17n.rb
@@ -1230,7 +1230,7 @@ class TestM17N < Test::Unit::TestCase

def testsymbolop
ops = %w"
- .. ... + - +(binary) -(binary) * / % ** +@ -@ | ^ & ! <=> > >= < <= ==
+ .. ... + - * / % ** +@ -@ | ^ & ! <=> > >= < <= ==
=== != =~ !~ ~ ! [] []= << >> :: `
"
ops.each do |op|

Associated revisions

Revision 43413
Added by Marc-Andre Lafortune 6 months ago

  • parse.y: Remove +(binary) and -(binary) special cases [Feature #9048]

History

#1 Updated by Yukihiro Matsumoto 6 months ago

  • Status changed from Open to Assigned
  • Assignee set to Marc-Andre Lafortune

I agree.

Matz.

#2 Updated by Marc-Andre Lafortune 6 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r43413.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • parse.y: Remove +(binary) and -(binary) special cases [Feature #9048]

#3 Updated by Tomoyuki Chikanaga 6 months ago

  • Tracker changed from Feature to Bug

I think it's a bug and 1.9.3/2.0.0 have save problem.

#4 Updated by Tomoyuki Chikanaga 6 months ago

  • Backport set to 1.9.3: REQUIRED, 2.0.0: REQUIRED
  • ruby -v set to -

#5 Updated by Tomoyuki Chikanaga 6 months ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED to 1.9.3: REQUIRED, 2.0.0: DONE

r43413 is backported to ruby20_0 branch at r43415.

#6 Updated by Usaku NAKAMURA 6 months ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: DONE to 1.9.3: DONE, 2.0.0: DONE

Backported to ruby19_3 at r43493.

Also available in: Atom PDF