Bug #9048: Remove legacy ±(binary) special cases.

• Status: Closed
• Assignee: marcandre (Marc-Andre Lafortune)
• Target version: -
• ruby -v: -
• Backport: 1.9.3: DONE, 2.0.0: DONE

[marcandre (Marc-Andre Lafortune)]

Is there any reason not to get rid of the following special cases?

'+(binary)'.to_sym # => :+ when expected :"+(binary)"

The following patch didn't reveal any failure in make test:

diff --git a/parse.y b/parse.y
index 76fc9e7..6550235 100644
--- a/parse.y
+++ b/parse.y
@@ -10045,8 +10045,6 @@ static const struct {
} op_tbl[] = {
{tDOT2, ".."},
{tDOT3, "..."},

• {'+', "+(binary)"},
• {'-', "-(binary)"},
  {tPOW, ""},
  {tDSTAR, ""},
  {tUPLUS, "+@"},
  diff --git a/test/ruby/test_m17n.rb b/test/ruby/test_m17n.rb
  index 7c37c8a..3ea346f 100644
  --- a/test/ruby/test_m17n.rb
  +++ b/test/ruby/test_m17n.rb
  @@ -1230,7 +1230,7 @@ class TestM17N < Test::Unit::TestCase

def test_symbol_op
ops = %w"

•  .. ... + - +(binary) -(binary) * / % ** +@ -@ | ^ & ! <=> > >= < <= ==
  

•  .. ... + - * / % ** +@ -@ | ^ & ! <=> > >= < <= ==
   === != =~ !~ ~ ! [] []= << >> :: `
  

  "
  ops.each do |op|

[matz (Yukihiro Matsumoto)]

• Status changed from Open to Assigned
• Assignee set to marcandre (Marc-Andre Lafortune)

I agree.

Matz.

[marcandre (Marc-Andre Lafortune)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r43413.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• parse.y: Remove +(binary) and -(binary) special cases [Feature #9048]

[nagachika (Tomoyuki Chikanaga)]

• Tracker changed from Feature to Bug

I think it's a bug and 1.9.3/2.0.0 have save problem.

[nagachika (Tomoyuki Chikanaga)]

• Backport set to 1.9.3: REQUIRED, 2.0.0: REQUIRED
• ruby -v set to -

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED to 1.9.3: REQUIRED, 2.0.0: DONE

r43413 is backported to ruby_2_0_0 branch at r43415.

[usa (Usaku NAKAMURA)]

• Backport changed from 1.9.3: REQUIRED, 2.0.0: DONE to 1.9.3: DONE, 2.0.0: DONE

Backported to ruby_1_9_3 at r43493.