Project

General

Profile

Bug #9048

Remove legacy ±(binary) special cases.

Added by marcandre (Marc-Andre Lafortune) about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
-
[ruby-core:57995]

Description

Is there any reason not to get rid of the following special cases?

'+(binary)'.to_sym # => :+ when expected :"+(binary)"

The following patch didn't reveal any failure in make test:

diff --git a/parse.y b/parse.y
index 76fc9e7..6550235 100644
--- a/parse.y
+++ b/parse.y
@@ -10045,8 +10045,6 @@ static const struct {
} op_tbl[] = {
{tDOT2, ".."},
{tDOT3, "..."},

  • {'+', "+(binary)"},
  • {'-', "-(binary)"}, {tPOW, ""}, {tDSTAR, ""}, {tUPLUS, "+@"}, diff --git a/test/ruby/test_m17n.rb b/test/ruby/test_m17n.rb index 7c37c8a..3ea346f 100644 --- a/test/ruby/test_m17n.rb +++ b/test/ruby/test_m17n.rb @@ -1230,7 +1230,7 @@ class TestM17N < Test::Unit::TestCase

def test_symbol_op
ops = %w"

  • .. ... + - +(binary) -(binary) * / % ** +@ -@ | ^ & ! <=> > >= < <= ==
  • .. ... + - * / % ** +@ -@ | ^ & ! <=> > >= < <= == === != =~ !~ ~ ! [] []= << >> :: ` " ops.each do |op|

Also available in: Atom PDF