Project

General

Profile

Bug #9093

Resolv: Multiple strings should be concatenated in a DNS record's data

Added by Zachary Scott over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
ruby -v:
2.1.0dev
Backport:
1.9.3: DONE, 2.0.0: DONE, 2.1: DONE
[ruby-core:58220]

Description

Moved from github [https://github.com/ruby/ruby/pull/389]:

"As per http://tools.ietf.org/html/rfc4408#section-3.1.3, when a TXT or SPF record contains multiple strings, those strings should be concatenated without any delimiter. Resolv was taking the first string, which meant that valid data in a TXT record wouldn't be available. This change just concatenates the strings together."

389.patch Magnifier (668 Bytes) Zachary Scott, 11/08/2013 02:59 AM

Associated revisions

Revision 44642
Added by Akira Tanaka about 2 years ago

  • lib/resolv.rb (Resolv::DNS::Resource::TXT#data): Return concatenated string. Patch by Ryan Brunner. [Bug #9093]

Revision 44642
Added by Akira Tanaka about 2 years ago

  • lib/resolv.rb (Resolv::DNS::Resource::TXT#data): Return concatenated string. Patch by Ryan Brunner. [Bug #9093]

History

#1 [ruby-core:59846] Updated by Akira Tanaka about 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset r44642.


  • lib/resolv.rb (Resolv::DNS::Resource::TXT#data): Return concatenated string. Patch by Ryan Brunner. [Bug #9093]

#2 [ruby-core:60472] Updated by Usaku NAKAMURA about 2 years ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED

#3 [ruby-core:60710] Updated by Usaku NAKAMURA almost 2 years ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: DONE, 2.0.0: REQUIRED, 2.1: REQUIRED

backported into ruby_1_9_3 at r44944.

#4 [ruby-core:60770] Updated by Tomoyuki Chikanaga almost 2 years ago

  • Backport changed from 1.9.3: DONE, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: DONE, 2.0.0: DONE, 2.1: REQUIRED

r44642 was backported to ruby_2_0_0 at r44983.

#5 [ruby-core:60981] Updated by Yui NARUSE almost 2 years ago

  • Backport changed from 1.9.3: DONE, 2.0.0: DONE, 2.1: REQUIRED to 1.9.3: DONE, 2.0.0: DONE, 2.1: DONE

r45114

Also available in: Atom PDF