Project

General

Profile

Actions

Bug #9129

closed

Regression in support for IPv6 literals in URIs with Net::HTTP

Added by kallistec (Daniel DeLeo) over 10 years ago. Updated about 9 years ago.

Status:
Closed
Target version:
ruby -v:
ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-darwin12.4.0]
[ruby-core:58438]

Description

The proxy code in Net::HTTP constructs a URI string by concatenating the address with the port. If the address is IPv6, this is incorrect, the address should be surrounded by square brackets. My code is failing in the Net::HTTP#proxy_uri method. The error can be reproduced by:

ruby -r'net/http' -e 'Net::HTTP.new("::1", 80).proxy_uri'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/generic.rb:214:in initialize': the scheme http does not accept registry part: ::1:80 (or bad hostname?) (URI::InvalidURIError) from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/http.rb:84:in initialize'
from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:214:in new' from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:214:in parse'
from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:747:in parse' from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:994:in URI'
from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/net/http.rb:1027:in proxy_uri' from -e:1:in '

Though I've not tried to reproduce on current trunk, the implementation of Net::HTTP#proxy_uri is unchanged from 2.0.0p0 and current trunk.

My application's tests pass if I monkey patch that method as follows:

  def proxy_uri # :nodoc:
    ipv6_safe_addr = address.to_s.include?(":") ? "[#{address}]" : address
    @proxy_uri ||= URI("http://#{ipv6_safe_addr}:#{port}").find_proxy
  end

Related issues 1 (0 open1 closed)

Related to Backport200 - Backport #10530: Backport r47079 to 2.0.0Closed11/20/2014Actions
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0