Bug #9374
closed[PATCH] ext/json: objects depend on $(ruby_headers)
Description
We must rebuild the extension on Ruby ABI changes, otherwise
we'll get mysterious test failures
I encountered this when switching between cachelined and normal trunk.
pull request:
The following changes since commit 2030e19a04e92ee3d4f605c15af0e1f115732813:
- 2014-01-07 (2014-01-06 19:38:25 +0000)
are available in the git repository at:
git://bogomips.org/ruby.git json-depend
for you to fetch changes up to 93ccc7f9f1feabc95231ee8bc39945f7e4eb432d:
ext/json: objects depend on $(ruby_headers) (2014-01-06 23:32:47 +0000)
Eric Wong (1):
ext/json: objects depend on $(ruby_headers)
ext/json/generator/depend | 1 +
ext/json/parser/depend | 1 +
2 files changed, 2 insertions(+)
Files
Updated by tmm1 (Aman Karmani) almost 11 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r44514.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
ext/json: objects depend on $(ruby_headers)
- ext/json/generator/depend: add build dependencies for json extension
Patch by normalperson (Eric Wong) [Bug #9374] [ruby-core:59609] - ext/json/parser/depend: ditto
Updated by usa (Usaku NAKAMURA) almost 11 years ago
- Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN to 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED
Updated by usa (Usaku NAKAMURA) almost 11 years ago
- Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: DONE, 2.0.0: REQUIRED, 2.1: REQUIRED
backported into ruby_1_9_3 at r44947.
Updated by nagachika (Tomoyuki Chikanaga) almost 11 years ago
- Backport changed from 1.9.3: DONE, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: DONE, 2.0.0: DONE, 2.1: REQUIRED
r44514 was backported to ruby_2_0_0 at r45009.
Updated by naruse (Yui NARUSE) almost 11 years ago
- Backport changed from 1.9.3: DONE, 2.0.0: DONE, 2.1: REQUIRED to 1.9.3: DONE, 2.0.0: DONE, 2.1: DONE
r45123