Project

General

Profile

Bug #9374

[PATCH] ext/json: objects depend on $(ruby_headers)

Added by normalperson (Eric Wong) over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
ruby 2.2.0dev (2014-01-07 trunk 44513) [x86_64-linux]
[ruby-core:59609]

Description

We must rebuild the extension on Ruby ABI changes, otherwise
we'll get mysterious test failures

I encountered this when switching between cachelined and normal trunk.

pull request:

The following changes since commit 2030e19a04e92ee3d4f605c15af0e1f115732813:

  • 2014-01-07 (2014-01-06 19:38:25 +0000)

are available in the git repository at:

git://bogomips.org/ruby.git json-depend

for you to fetch changes up to 93ccc7f9f1feabc95231ee8bc39945f7e4eb432d:

ext/json: objects depend on $(ruby_headers) (2014-01-06 23:32:47 +0000)


Eric Wong (1):
ext/json: objects depend on $(ruby_headers)

ext/json/generator/depend | 1 +
ext/json/parser/depend | 1 +
2 files changed, 2 insertions(+)

Associated revisions

Revision 738b8872
Added by tmm1 (Aman Gupta) over 4 years ago

ext/json: objects depend on $(ruby_headers)

  • ext/json/generator/depend: add build dependencies for json extension Patch by normalperson (Eric Wong) [Bug #9374]
  • ext/json/parser/depend: ditto

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44514 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 44514
Added by tmm1 (Aman Gupta) over 4 years ago

ext/json: objects depend on $(ruby_headers)

  • ext/json/generator/depend: add build dependencies for json extension Patch by normalperson (Eric Wong) [Bug #9374]
  • ext/json/parser/depend: ditto

Revision 44514
Added by tmm1 (Aman Gupta) over 4 years ago

ext/json: objects depend on $(ruby_headers)

  • ext/json/generator/depend: add build dependencies for json extension Patch by normalperson (Eric Wong) [Bug #9374]
  • ext/json/parser/depend: ditto

Revision 44514
Added by tmm1 (Aman Gupta) over 4 years ago

ext/json: objects depend on $(ruby_headers)

  • ext/json/generator/depend: add build dependencies for json extension Patch by normalperson (Eric Wong) [Bug #9374]
  • ext/json/parser/depend: ditto

Revision 44514
Added by tmm1 (Aman Gupta) over 4 years ago

ext/json: objects depend on $(ruby_headers)

  • ext/json/generator/depend: add build dependencies for json extension Patch by normalperson (Eric Wong) [Bug #9374]
  • ext/json/parser/depend: ditto

Revision 44514
Added by tmm1 (Aman Gupta) over 4 years ago

ext/json: objects depend on $(ruby_headers)

  • ext/json/generator/depend: add build dependencies for json extension Patch by normalperson (Eric Wong) [Bug #9374]
  • ext/json/parser/depend: ditto

Revision 681d225d
Added by usa (Usaku NAKAMURA) over 4 years ago

merge revision(s) 44514: [Backport #9374]

* ext/json/generator/depend: add build dependencies for json extension
  [Bug #9374] 

* ext/json/parser/depend: ditto

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@44947 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision bdcadb8c
Added by nagachika (Tomoyuki Chikanaga) over 4 years ago

merge revision(s) r44514: [Backport #9374]

* ext/json/generator/depend: add build dependencies for json extension
  [Bug #9374] 

* ext/json/parser/depend: ditto

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@45009 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 7329f404
Added by naruse (Yui NARUSE) about 4 years ago

merge revision(s) 44514: [Backport #9374]

* ext/json/generator/depend: add build dependencies for json extension
  [Bug #9374] 

* ext/json/parser/depend: ditto

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@45123 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

History

#1 Updated by tmm1 (Aman Gupta) over 4 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r44514.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


ext/json: objects depend on $(ruby_headers)

  • ext/json/generator/depend: add build dependencies for json extension Patch by normalperson (Eric Wong) [Bug #9374]
  • ext/json/parser/depend: ditto

#2 [ruby-core:60488] Updated by usa (Usaku NAKAMURA) over 4 years ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN to 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED

#3 [ruby-core:60712] Updated by usa (Usaku NAKAMURA) over 4 years ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: DONE, 2.0.0: REQUIRED, 2.1: REQUIRED

backported into ruby_1_9_3 at r44947.

#4 [ruby-core:60788] Updated by nagachika (Tomoyuki Chikanaga) over 4 years ago

  • Backport changed from 1.9.3: DONE, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: DONE, 2.0.0: DONE, 2.1: REQUIRED

r44514 was backported to ruby_2_0_0 at r45009.

#5 [ruby-core:61004] Updated by naruse (Yui NARUSE) about 4 years ago

  • Backport changed from 1.9.3: DONE, 2.0.0: DONE, 2.1: REQUIRED to 1.9.3: DONE, 2.0.0: DONE, 2.1: DONE

r45123

Also available in: Atom PDF