Project

General

Profile

Actions

Bug #1308

closed

bigdecimal debug code prevents tests from running

Added by cfis (Charlie Savage) about 15 years ago. Updated almost 13 years ago.

Status:
Closed
Target version:
ruby -v:
ruby 1.9.2dev (2009-03-21) [i386-mswin32_90]
Backport:
[ruby-core:22989]

Description

=begin
Trying to get ruby's test suite running on windows (not passing, just running).

If compiled with -DEBUG set, the bigdecimal extension prints out a bunch of information (it really shoulnd't) and then asks for user input via getchar() calls. That needless to say stops the test suite in its track.

Patch attached. Note it also includes the bigdecimal patch from #1280.
=end


Files

bigdecimal2.patch (862 Bytes) bigdecimal2.patch cfis (Charlie Savage), 03/22/2009 04:44 PM
Actions #1

Updated by ujihisa (Tatsuhiro Ujihisa) over 14 years ago

  • Status changed from Open to Assigned
  • Assignee set to usa (Usaku NAKAMURA)

=begin

=end

Actions #2

Updated by usa (Usaku NAKAMURA) over 14 years ago

  • Status changed from Assigned to Open
  • Assignee deleted (usa (Usaku NAKAMURA))

=begin
this is the issue of bigdecimal itself.
but currently bigdecimal has no maintainer... :-(
=end

Actions #3

Updated by wanabe (_ wanabe) almost 14 years ago

  • Status changed from Open to Assigned
  • Assignee set to mrkn (Kenta Murata)
  • Target version changed from 1.9.1 to 1.9.2

=begin

=end

Actions #4

Updated by mame (Yusuke Endoh) almost 14 years ago

=begin
Hi,

If compiled with -DEBUG set, the bigdecimal extension prints out a bunch of information (it really shoulnd't) and then asks for user input via getchar() calls.

Don't compile with -DEBUG set :-)

But, -DEBUG is too easy to conflict other projects.
How about replacing DEBUG with BIGDECIMAL_DEBUG?

Anyway, mrkn, please decide and fix.

Note it also includes the bigdecimal patch from #1280.

This is already fixed. Thanks.

--
Yusuke Endoh
=end

Actions #5

Updated by mrkn (Kenta Murata) almost 14 years ago

=begin
I've committed the change to replace _DEBUG with BIGDECIMAL_DEBUG.

=end

Actions #6

Updated by mrkn (Kenta Murata) almost 14 years ago

  • Status changed from Assigned to Closed

=begin

=end

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0