Bug #13163: Uncaught exceptions may not be reported when Thread#report_on_exception=true and Thread#abort_on_exception=true

• Status: Closed
• Priority: Normal
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: -
• Backport: 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONE

[tagomoris (Satoshi TAGOMORI)]

When we set true on both of Thread#report_on_exception and Thread#abort_on_exception, it just works as Thread#abort_on_exception and raised error will be re-raised in main thread.
But in our case, main thread sometimes in begin-rescue clause, or sometimes out of begin-rescue clause.
When main thread in begin-rescue clause (and main thread code may raise errors in their own business), we cannot know that threads are dead by errors.

What I expected by specifying both of Thread#report_on_exception=true and Thread#abort_on_exception=true:

• "Thread terminated with exception" is reported always (even if Thread#abort_on_exception is set)
• Raised error is re-raised in main thread if Thread#abort_on_exception is true

How do you think about this idea?

[shyouhei (Shyouhei Urabe)]

No objection.

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Feedback
• Description updated (diff)

Isn't this a bug?
https://github.com/nobu/ruby/tree/bug/13163-report-before-abort-on-exception

[Eregon (Benoit Daloze)]

+1
The patch looks good.
The message of the assert_warn should be changed though.

[naruse (Yui NARUSE)]

• Backport set to 2.2: DONTNEED, 2.3: REQUIRED, 2.4: REQUIRED
• Assignee set to nobu (Nobuyoshi Nakada)
• Status changed from Feedback to Assigned
• Tracker changed from Misc to Bug

Hmm, indeed this seems considered a bug.
@nobu (Nobuyoshi Nakada) Could you commit it?

[nobu (Nobuyoshi Nakada)]

• Status changed from Assigned to Closed

Applied in changeset trunk|r59963.

---

thread.c: report then abort

• thread.c (thread_start_func_2): report then abort on exception,
  if both are set. [ruby-core:79280] [Bug #13163]

[Eregon (Benoit Daloze)]

• Backport changed from 2.2: DONTNEED, 2.3: REQUIRED, 2.4: REQUIRED to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: REQUIRED

I believe we only need a 2.4 backport, Thread#report_on_exception is only defined from Ruby 2.4+.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.2: DONTNEED, 2.3: DONTNEED, 2.4: REQUIRED to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONE

ruby_2_4 r62711 merged revision(s) 59963.