Project

General

Profile

Bug #13655

external encoding named "-" (doc issue or…?)

Added by shyouhei (Shyouhei Urabe) almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
ruby 2.5.0dev (2017-06-09 trunk 59055) [x86_64-darwin15]
[ruby-core:81665]

Description

IO.new's document explicitly states that it accepts "-" as external encoding:

https://github.com/ruby/ruby/blob/d0015e4ac6b812ea1681b1f5fa86fbab52a58960/io.c#L7790

which is not true.

% ruby -ve 'IO.new(0, external_encoding: "-")'
ruby 2.5.0dev (2017-06-09 trunk 59055) [x86_64-darwin15]
Traceback (most recent call last):
        2: from -e:1:in `<main>'
        1: from -e:1:in `new'
-e:1:in `initialize': unknown encoding name - - (ArgumentError)

Associated revisions

Revision 9fa7722b
Added by naruse (Yui NARUSE) over 1 year ago

IO.new doesn't recive "-" as external_encoding [Bug #13655]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 61278
Added by naruse (Yui NARUSE) over 1 year ago

IO.new doesn't recive "-" as external_encoding [Bug #13655]

Revision 61278
Added by naruse (Yui NARUSE) over 1 year ago

IO.new doesn't recive "-" as external_encoding [Bug #13655]

Revision 61278
Added by naruse (Yui NARUSE) over 1 year ago

IO.new doesn't recive "-" as external_encoding [Bug #13655]

Revision a9419fbd
Added by kazu over 1 year ago

[DOC] IO.new accepts external_encoding

Revert part of r61278 [Bug #13655]
[ci skip]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61281 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 61281
Added by znz (Kazuhiro NISHIYAMA) over 1 year ago

[DOC] IO.new accepts external_encoding

Revert part of r61278 [Bug #13655]
[ci skip]

Revision 61281
Added by kazu over 1 year ago

[DOC] IO.new accepts external_encoding

Revert part of r61278 [Bug #13655]
[ci skip]

Revision 61281
Added by kazu over 1 year ago

[DOC] IO.new accepts external_encoding

Revert part of r61278 [Bug #13655]
[ci skip]

Revision cc163957
Added by nagachika (Tomoyuki Chikanaga) about 1 year ago

merge revision(s) 61278,61281: [Backport #13655]

    IO.new doesn't recive "-" as external_encoding [Bug #13655]

    [DOC] `IO.new` accepts `external_encoding`

    Revert part of r61278 [Bug #13655]
    [ci skip]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62846 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 62846
Added by nagachika (Tomoyuki Chikanaga) about 1 year ago

merge revision(s) 61278,61281: [Backport #13655]

IO.new doesn't recive "-" as external_encoding [Bug #13655]

[DOC] `IO.new` accepts `external_encoding`

Revert part of r61278 [Bug #13655]
[ci skip]

Revision b24443d3
Added by usa (Usaku NAKAMURA) about 1 year ago

merge revision(s) 61278,61281: [Backport #13655]

    IO.new doesn't recive "-" as external_encoding [Bug #13655]

    [DOC] `IO.new` accepts `external_encoding`

    Revert part of r61278 [Bug #13655]
    [ci skip]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@62937 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 62937
Added by usa (Usaku NAKAMURA) about 1 year ago

merge revision(s) 61278,61281: [Backport #13655]

IO.new doesn't recive "-" as external_encoding [Bug #13655]

[DOC] `IO.new` accepts `external_encoding`

Revert part of r61278 [Bug #13655]
[ci skip]

History

Updated by nobu (Nobuyoshi Nakada) almost 2 years ago

I think it a doc issue.

Updated by shyouhei (Shyouhei Urabe) almost 2 years ago

  • Assignee set to stomar (Marcus Stollsteimer)
  • Status changed from Open to Assigned

We looked at this issue at yesterday's developer meeting and none of attendees remembered there has been any plans to have this feature. It seems to be a doc issue. Please delete this part.

#3

Updated by naruse (Yui NARUSE) over 1 year ago

  • Status changed from Assigned to Closed

Applied in changeset trunk|r61278.


IO.new doesn't recive "-" as external_encoding [Bug #13655]

Updated by nagachika (Tomoyuki Chikanaga) about 1 year ago

  • Backport changed from 2.2: REQUIRED, 2.3: REQUIRED, 2.4: REQUIRED to 2.2: REQUIRED, 2.3: REQUIRED, 2.4: DONE

ruby_2_4 r62846 merged revision(s) 61278,61281.

Updated by usa (Usaku NAKAMURA) about 1 year ago

  • Backport changed from 2.2: REQUIRED, 2.3: REQUIRED, 2.4: DONE to 2.2: REQUIRED, 2.3: DONE, 2.4: DONE

ruby_2_3 r62937 merged revision(s) 61278,61281.

Also available in: Atom PDF