Project

General

Profile

Feature #14091

Remove Time#succ

Added by pixeltrix (Andrew White) over 1 year ago. Updated over 1 year ago.

Status:
Assigned
Priority:
Normal
Target version:
-
[ruby-core:83696]

Description

The method Time#succ was marked as obsolete in Ruby 1.9.3 and whilst it remains Rails has to patch Range#each and Range#step to prevent logs from being filled with the deprecation messages (see https://github.com/rails/rails/pull/11474). It's been over 8 years now which seems like a more than adequate period to wait before removal.


Files

remove-time-succ.diff (3.81 KB) remove-time-succ.diff pixeltrix (Andrew White), 11/07/2017 02:44 PM

History

Updated by shevegen (Robert A. Heiler) over 1 year ago

Interesting.

If this is true, perhaps ruby core forgot about it.

I had a look at the current docu for Time:

https://ruby-doc.org/core/Time.html

https://ruby-doc.org/core-2.4.2/Time.html#method-i-succ

The documentation reads:

"Returns a new Time object, one second later than time. #succ is obsolete
since 1.9.2 for time is not a discrete value."

So I am inclined to agree with Andrew - either it is indeed obsolete, in
which case it may be time to remove it; and if it is not obsolete, then
the documentation should change, IMO.

(On a side note, perhaps there could be a simple way to ask Ruby which
methods may be deprecated or so... Kernel#deprecated_methods? or something,
but anyway, I should file an own issue request for that; I just don't
know if other people may find that useful. Sorry for side-tracking from
the main issue thread here for a moment!)

Updated by hsbt (Hiroshi SHIBATA) over 1 year ago

  • Assignee set to akr (Akira Tanaka)
  • Status changed from Open to Assigned

Also available in: Atom PDF