Project

General

Profile

Bug #15425

Store MJIT header into Ruby versioned directory.

Added by vo.x (Vit Ondruch) 6 months ago. Updated 6 months ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 2.6.0rc2 (2018-12-15 trunk 66408) [x86_64-linux]
[ruby-core:90585]

Description

This is a followup of #15391 which fixes JIT to respect the configuration options. However, I still wonder, why the file is versioned and why it is not stored in the versioned directory alongside all other internal Ruby headers. I believe, that while it now respects the header configuration flags, it still does not respect options such as "--with-ruby-version"

History

Updated by nobu (Nobuyoshi Nakada) 6 months ago

  • Status changed from Open to Feedback

It should be placed under the directory which has the version and architecture name.
How did you configure it?

Updated by vo.x (Vit Ondruch) 6 months ago

I am using --with-rubyhdrdir=/usr/include --with-rubyarchhdrdir=/usr/include --enable-multiarch configuration options. This is the output:

$ tree
.
`-- ruby-2.6.0
    |-- ruby
    |   |-- backward
    |   |   |-- classext.h
    |   |   |-- rubyio.h
    |   |   |-- rubysig.h
    |   |   |-- st.h
    |   |   `-- util.h
    |   |-- backward.h
    |   |-- debug.h
    |   |-- defines.h
    |   |-- digest.h
    |   |-- encoding.h
    |   |-- intern.h
    |   |-- io.h
    |   |-- missing.h
    |   |-- onigmo.h
    |   |-- oniguruma.h
    |   |-- re.h
    |   |-- regex.h
    |   |-- ruby.h
    |   |-- st.h
    |   |-- subst.h
    |   |-- thread.h
    |   |-- thread_native.h
    |   |-- util.h
    |   |-- version.h
    |   `-- vm.h
    |-- ruby-2.6.0
    |   `-- x86_64-linux
    |-- ruby.h
    `-- x86_64-linux
        |-- rb_mjit_min_header-2.6.0.h
        `-- ruby
            `-- config.h

7 directories, 28 files

Different headers respect the configuration differently. The header should be probably placed on the same location as "config.h" for consistency. The ruby-2.6.0/ruby-2.6.0/x86_64-linux should not be created at all.

#3

Updated by vo.x (Vit Ondruch) 6 months ago

  • Status changed from Feedback to Open

Also available in: Atom PDF