Project

General

Profile

Actions

Bug #18475

closed

Yielding an element for Enumerator in another thread dumps core

Added by mame (Yusuke Endoh) about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 3.1.0p0 (2021-12-25 revision fb4df44d16) [x86_64-linux]
[ruby-core:107059]

Description

I faced [BUG] when investigating #18474

def run
  Thread.new do
    1.times do |value|
      yield "some-value"
    end
  end.join
end

to_enum(:run).first
$ ruby repro.rb
#<Thread:0x00007fcab26af0c0 repro.rb:2 run> terminated with exception (report_on_exception is true):
[BUG] Segmentation fault at 0x0000000000000018
ruby 3.1.0p0 (2021-12-25 revision fb4df44d16) [x86_64-linux]

-- Control frame information -----------------------------------------------
c:0001 p:---- s:0003 e:000002 (none) [FINISH]


-- Machine register context ------------------------------------------------
 RIP: 0x0000561c86b90c25 RBP: 0x0000000000000000 RSP: 0x00007fcab259d970
 RAX: 0x0000000000000000 RBX: 0x00007fcab259d9f8 RCX: 0x0000000000002021
 RDX: 0x00007fcab259d9f8 RDI: 0x0000000000000000 RSI: 0x000000000000009b
  R8: 0x0000000000000001  R9: 0x0000000000000000 R10: 0x0000000000000000
 R11: 0x0000000000000293 R12: 0x0000000000000000 R13: 0x00007fcab26aec60
 R14: 0x0000000000002021 R15: 0x000000000000009b EFL: 0x0000000000010202

-- C level backtrace information -------------------------------------------
/home/mame/local/bin/ruby(rb_print_backtrace+0x11) [0x561c86bb541d] vm_dump.c:759
/home/mame/local/bin/ruby(rb_vm_bugreport) vm_dump.c:1045
/home/mame/local/bin/ruby(rb_bug_for_fatal_signal+0xec) [0x561c86c7e45c] error.c:820
/home/mame/local/bin/ruby(sigsegv+0x4d) [0x561c86b0898d] signal.c:964
/lib/x86_64-linux-gnu/libpthread.so.0(__restore_rt+0x0) [0x7fcab64ff1f0] ../sysdeps/pthread/funlockfile.c:28
/home/mame/local/bin/ruby(cached_callable_method_entry+0x0) [0x561c86b90c25] vm_sync.h:40
/home/mame/local/bin/ruby(callable_method_entry) vm_method.c:1316
/home/mame/local/bin/ruby(vm_respond_to+0x3f) [0x561c86ba099f] vm_method.c:2693
/home/mame/local/bin/ruby(check_funcall_respond_to+0xb) [0x561c86ba137c] vm_eval.c:603
/home/mame/local/bin/ruby(rb_check_funcall_default_kw) vm_eval.c:677
/home/mame/local/bin/ruby(rb_get_message+0x18) [0x561c86c7ea98] error.c:1231
/home/mame/local/bin/ruby(rb_ec_error_print+0x1c3) [0x561c869a9983] eval_error.c:378
/home/mame/local/bin/ruby(thread_start_func_2+0x6d7) [0x561c86b50737] thread.c:847
/home/mame/local/bin/ruby(rb_native_cond_initialize+0x0) [0x561c86b50dc9] thread_pthread.c:1047
/home/mame/local/bin/ruby(register_cached_thread_and_wait) thread_pthread.c:1099
/home/mame/local/bin/ruby(thread_start_func_1) thread_pthread.c:1054
/lib/x86_64-linux-gnu/libpthread.so.0(start_thread+0xe0) [0x7fcab64f4450] pthread_create.c:473
/lib/x86_64-linux-gnu/libpthread.so.0(start_thread) (null):0
/lib/x86_64-linux-gnu/libc.so.6(clone+0x43) [0x7fcab627ad53] ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Related issues 4 (0 open4 closed)

Related to Ruby master - Feature #17613: Eliminate useless catch tables and nops from lambdasClosedActions
Related to Ruby master - Bug #11254: [BUG] no corresponding cfpClosednobu (Nobuyoshi Nakada)Actions
Related to Ruby master - Bug #18474: 938e027c seems to have caused a regression in yield handling with concurrent-rubyClosedActions
Has duplicate Ruby master - Bug #18637: Segmentation fault for yield inside another ThreadClosedActions
Actions #1

Updated by mame (Yusuke Endoh) about 2 years ago

  • Related to Feature #17613: Eliminate useless catch tables and nops from lambdas added
Actions #2

Updated by mame (Yusuke Endoh) about 2 years ago

  • Related to Bug #11254: [BUG] no corresponding cfp added
Actions #3

Updated by mame (Yusuke Endoh) about 2 years ago

  • Related to Bug #18474: 938e027c seems to have caused a regression in yield handling with concurrent-ruby added

Updated by mame (Yusuke Endoh) about 2 years ago

This is almost the same issue as #11254. When TAG_BREAK is thrown to the top-level frame, it dumps core. #11254 fixed the case where TAG_BREAK is thrown to the top-level of the main thread, but not of a non-main thread.

I think this patch will fix the issue. It converts uncaught TAG_BREAK (or other non-local jumps) to a normal exception at the top-level of a thread.

diff --git a/thread.c b/thread.c
index 36723c6fc0..cf6e89327e 100644
--- a/thread.c
+++ b/thread.c
@@ -830,6 +830,9 @@ thread_start_func_2(rb_thread_t *th, VALUE *stack_start)
     else {
         errinfo = th->ec->errinfo;

+        VALUE exc = rb_vm_make_jump_tag_but_local_jump(state, Qundef);
+        if (!NIL_P(exc)) errinfo = exc;
+
         if (state == TAG_FATAL) {
             if (th->invoke_type == thread_invoke_type_ractor_proc) {
                 rb_ractor_atexit(th->ec, Qnil);
Actions #6

Updated by mame (Yusuke Endoh) about 2 years ago

  • Status changed from Open to Closed

Applied in changeset git|ae5458f228a5477383e9c00425d85d50a3867817.


thread.c: Convert TAG_BREAK to a normal exception at thread top-level

[Bug #18475]

Actions #7

Updated by mame (Yusuke Endoh) about 2 years ago

  • Backport changed from 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN to 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED

Updated by naruse (Yui NARUSE) about 2 years ago

  • Backport changed from 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED to 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONE

ruby_3_1 8e3bce0841497fc00ccdaf45f6583c25720a2d3f merged revision(s) ae5458f228a5477383e9c00425d85d50a3867817.

Updated by nagachika (Tomoyuki Chikanaga) about 2 years ago

  • Backport changed from 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONE to 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: DONE, 3.1: DONE

ruby_3_0 42b1e87ba7856f92973924985a63a60b5fa750c8 merged revision(s) ae5458f228a5477383e9c00425d85d50a3867817.

Actions #10

Updated by Eregon (Benoit Daloze) about 2 years ago

  • Related to Bug #18637: Segmentation fault for yield inside another Thread added
Actions #11

Updated by Eregon (Benoit Daloze) about 2 years ago

  • Has duplicate Bug #18637: Segmentation fault for yield inside another Thread added
Actions #12

Updated by Eregon (Benoit Daloze) about 2 years ago

  • Related to deleted (Bug #18637: Segmentation fault for yield inside another Thread)
Actions #13

Updated by usa (Usaku NAKAMURA) almost 2 years ago

  • Backport changed from 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: DONE, 3.1: DONE to 2.6: UNKNOWN, 2.7: DONE, 3.0: DONE, 3.1: DONE
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0