Project

General

Profile

Actions

Misc #21630

open

Suggest @Earlopain for core contributor

Misc #21630: Suggest @Earlopain for core contributor
1

Added by kddnewton (Kevin Newton) 20 days ago. Updated 6 days ago.

Status:
Open
Assignee:
-
[ruby-core:<unknown>]

Description

@Earlopain has been prolifically contributing to Prism for over a year, in addition to other various changes around ruby/ruby, like 96fdaf2e, 3826019f, a82e7132, and many more.

I would very much like @Earlopain to be able to merge their own contributions to Ruby, since they have been of such high quality for so long.

Updated by Earlopain (Earlopain _) 20 days ago Actions #1

This is certainly a bit unexpected to me. I really appreciate your vote of confidence, thank you.

I have spent most of my time for ruby on prism itself:

  • Mostly the C parser as of late (and rarely prism_compile.c if needed)
  • Before that, I made sure that the prism AST translation for the parser gem was in a usable state for RuboCop

I do want to make it very clear that I actually have no idea what I'm doing. I never went deep into C as a language and also have no knowledge of parser internals and how they're supposed to work/be written. That seems to have went well enough given this ticket I suppose. Take that as first-hand proof that prism is rather easy to contribute to.

With that disclaimer out of the way, I wouldn't mind it. Prism is a great achievement and I want to make sure that it is as good as it can be, as far as I am able. I like writing Ruby more than writing Ruby tooling in C, but for this I will make an exception (;

Updated by Eregon (Benoit Daloze) 20 days ago Actions #2

+1, @Earlopain has been proactive to fix important prism-related issues reported on this tracker as well as many contributions to making Prism better, and both have proven to be essential.

Updated by tenderlovemaking (Aaron Patterson) 20 days ago Actions #3

+1, I really appreciate @Earlopain's contributions, and I think they would make a great addition to the team (especially helping with Prism)

Updated by k0kubun (Takashi Kokubun) 20 days ago Actions #4

+1, @Earlopain has helped me on Prism backports to ruby_3_4 and been very helpful. Having them in the team would help us in more places like Prism sync to ruby/ruby.

Updated by byroot (Jean Boussier) 20 days ago Actions #5

+1, I haven't followed prism too closely but @Earlopain has been showing up constantly in many issues all across Ruby and the entire ecosystem.

Updated by naruse (Yui NARUSE) 6 days ago ยท Edited Actions #6 [ruby-core:123529]

I agree that they have made many significant contributions to Prism this year. However, they do not yet have permissions for the ruby/prism repository. Perhaps we could first grant them access to ruby/prism, with Kevin serving as their mentor, allowing them to gain experience in building consensus when pressing the merge button and in handling cases where merged commits fail with mentoring by Kevin, before considering granting them permissions to the core repository.

Updated by matz (Yukihiro Matsumoto) 6 days ago Actions #7 [ruby-core:123532]

I agree with @naruse (Yui NARUSE). We will revisit this issue some time (a few months?) later.

Matz.

Updated by Earlopain (Earlopain _) 6 days ago 1Actions #8 [ruby-core:123534]

That would be totally fine with me. I only have 3 PRs related to prism merged in ruby/ruby which is not all that much. For these I'm sure I'd find someone who'd occasionally help me out, like it is right now already anyways.

Thanks for considering me! Thanks also to @Eregon (Benoit Daloze), @tenderlovemaking (Aaron Patterson), @k0kubun (Takashi Kokubun), and @byroot (Jean Boussier). You all do great work related to Ruby, the +1's from you mean a lot to me.

Actions

Also available in: PDF Atom