Project

General

Profile

Actions

Bug #3071

closed

Convert rubygems and rdoc to use psych

Bug #3071: Convert rubygems and rdoc to use psych

Added by tenderlovemaking (Aaron Patterson) over 15 years ago. Updated over 14 years ago.

Status:
Rejected
Target version:
-
ruby -v:
ruby 1.9.2dev (2010-03-31 trunk 27130) [x86_64-darwin10.2.0]
Backport:
[ruby-core:29179]

Description

=begin
Rubygems and rdoc should be converted to use psych. The attached patch converts them.
=end


Files

rgems.patch (17.2 KB) rgems.patch tenderlovemaking (Aaron Patterson), 04/01/2010 05:35 AM

Updated by headius (Charles Nutter) over 15 years ago Actions #1

=begin
Doesn't this mean the the RubyGems codevase would now be forked
between 1.8 and 1.9? And not work on any impls that don't have Psych
yet?

On Wednesday, March 31, 2010, Aaron Patterson wrote:

Bug #3071: Convert rubygems and rdoc to use psych
http://redmine.ruby-lang.org/issues/show/3071

Author: Aaron Patterson
Status: Open, Priority: Normal
Assigned to: Eric Hodel
ruby -v: ruby 1.9.2dev (2010-03-31 trunk 27130) [x86_64-darwin10.2.0]

Rubygems and rdoc should be converted to use psych.  The attached patch converts them.


http://redmine.ruby-lang.org

=end

Updated by bitsweat (Jeremy Daer) over 15 years ago Actions #2

=begin
On Wed, Mar 31, 2010 at 2:43 PM, Charles Oliver Nutter
wrote:

Doesn't this mean the the RubyGems codevase would now be forked
between 1.8 and 1.9? And not work on any impls that don't have Psych
yet?

The patch uses psych or yaml according to availability.

jeremy

=end

Updated by nobu (Nobuyoshi Nakada) over 15 years ago Actions #3

  • Status changed from Open to Rejected
  • Assignee changed from drbrain (Eric Hodel) to tenderlovemaking (Aaron Patterson)

=begin
Psych must provide YAML compatible layer instead.

=end

Updated by drbrain (Eric Hodel) over 15 years ago Actions #4

=begin
I don't understand, this patch seems to use a YAML compatible layer so it will work with both Psych and syck
=end

Updated by nobu (Nobuyoshi Nakada) over 15 years ago Actions #5

=begin
Hi,

At Thu, 1 Apr 2010 14:21:56 +0900,
Aaron Patterson wrote in [ruby-core:29197]:

Psych must provide YAML compatible layer instead.

I don't understand. Should I provide the YAML constant too?

And lib/yaml.rb should select Syck or Psych. If so, users can
choose either, probably at configuration. It's a bad idea to
let all libraries write such selection.

Rather I want move lib/yaml to ext/syck/lib, and incorporate
your yamler into lib/yaml.rb. Also, ext/{syck,psych} should
go to below of ext/yaml, I think.

--
Nobu Nakada

=end

Updated by naruse (Yui NARUSE) over 15 years ago Actions #6

=begin
NOTE: Ruby::Specification#to_yaml uses deprecated API: YAML.quick_emit.
=end

Actions

Also available in: PDF Atom