Project

General

Profile

Actions

Bug #5339

closed

ERB generates extra newlines on Windows

Added by DNNX (Viktar Basharymau) over 12 years ago. Updated over 6 years ago.

Status:
Closed
Target version:
ruby -v:
ruby 1.9.2p290 (2011-07-09) [i386-mingw32]
[ruby-core:39625]

Description

Steps to reproduce:

(1) Create files from this gist: https://gist.github.com/1226780.
(2) Run ruby erbug.rb.
(3) If you're on windows, you'll see something like

  • 1

    • 2

      • 3
        Otherwise, it will be like this:
  • 1

    • 2
      • 3

This bug also affects bundler gem (see https://github.com/carlhuda/bundler/issues/1371).

Updated by ko1 (Koichi Sasada) about 12 years ago

  • Category set to lib
  • Status changed from Open to Assigned
  • Assignee set to seki (Masatoshi Seki)

Updated by hsbt (Hiroshi SHIBATA) almost 7 years ago

  • Assignee changed from seki (Masatoshi Seki) to k0kubun (Takashi Kokubun)
  • Target version set to 2.5
Actions #3

Updated by k0kubun (Takashi Kokubun) almost 7 years ago

  • Is duplicate of Bug #11464: ERB trimming doesn't trim carriage returns added
Actions #4

Updated by k0kubun (Takashi Kokubun) almost 7 years ago

  • Is duplicate of deleted (Bug #11464: ERB trimming doesn't trim carriage returns)
Actions #5

Updated by k0kubun (Takashi Kokubun) almost 7 years ago

  • Status changed from Assigned to Closed

Applied in changeset trunk|r58825.


erb.rb: Allow explicit trimming carriage return

when trim_mode is "-", for Windows environments.

[ruby-core:39625] [Bug #5339]

Actions #6

Updated by nagachika (Tomoyuki Chikanaga) almost 7 years ago

  • Backport changed from 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN to 2.2: REQUIRED, 2.3: REQUIRED, 2.4: REQUIRED

Updated by usa (Usaku NAKAMURA) over 6 years ago

  • Backport changed from 2.2: REQUIRED, 2.3: REQUIRED, 2.4: REQUIRED to 2.2: REQUIRED, 2.3: DONE, 2.4: REQUIRED

ruby_2_3 r59226 merged revision(s) 58825,58826.

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • Backport changed from 2.2: REQUIRED, 2.3: DONE, 2.4: REQUIRED to 2.2: REQUIRED, 2.3: DONE, 2.4: DONE

ruby_2_4 r59301 merged revision(s) 58825,58826.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0