Bug #5339: ERB generates extra newlines on Windows

• Status: Closed
• Assignee: k0kubun (Takashi Kokubun)
• Target version: 2.5
• ruby -v: ruby 1.9.2p290 (2011-07-09) [i386-mingw32]
• Backport: 2.2: REQUIRED, 2.3: DONE, 2.4: DONE

[DNNX (Viktar Basharymau)]

Steps to reproduce:

(1) Create files from this gist: https://gist.github.com/1226780.
(2) Run ruby erbug.rb.
(3) If you're on windows, you'll see something like

• 1

  • 2

    • 3
      Otherwise, it will be like this:

• 1

  • 2
    • 3

This bug also affects bundler gem (see https://github.com/carlhuda/bundler/issues/1371).

[ko1 (Koichi Sasada)]

• Category set to lib
• Status changed from Open to Assigned
• Assignee set to seki (Masatoshi Seki)

[hsbt (Hiroshi SHIBATA)]

• Assignee changed from seki (Masatoshi Seki) to k0kubun (Takashi Kokubun)
• Target version set to 2.5

[k0kubun (Takashi Kokubun)]

• Is duplicate of Bug #11464: ERB trimming doesn't trim carriage returns added

[k0kubun (Takashi Kokubun)]

• Is duplicate of deleted (Bug #11464: ERB trimming doesn't trim carriage returns)

[k0kubun (Takashi Kokubun)]

• Status changed from Assigned to Closed

Applied in changeset trunk|r58825.

---

erb.rb: Allow explicit trimming carriage return

when trim_mode is "-", for Windows environments.

[ruby-core:39625] [Bug #5339]

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN to 2.2: REQUIRED, 2.3: REQUIRED, 2.4: REQUIRED

[usa (Usaku NAKAMURA)]

• Backport changed from 2.2: REQUIRED, 2.3: REQUIRED, 2.4: REQUIRED to 2.2: REQUIRED, 2.3: DONE, 2.4: REQUIRED

ruby_2_3 r59226 merged revision(s) 58825,58826.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.2: REQUIRED, 2.3: DONE, 2.4: REQUIRED to 2.2: REQUIRED, 2.3: DONE, 2.4: DONE

ruby_2_4 r59301 merged revision(s) 58825,58826.