Project

General

Profile

Feature #7181

New Methods On OpenSSL::OCSP::CertificateId

Added by Paul Kehrer almost 4 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
openssl
[ruby-core:48062]

Description

This patch adds 3 new methods to OpenSSL::OCSP::CertificateId. These methods are useful when building an OCSP responder or doing comparison without repeatedly calling OpenSSL::OCSP::CertificateId#cmp_issuer

#issuer_name_hash
#issuer_key_hash
#signature_algorithm (returns string representation of alg used just like OpenSSL::X509::Certificate#signature_algorithm or OpenSSL::X509::Request#signature_algorithm)

Martin, I assigned this one to you since you helped me with the last OpenSSL patch I submitted, but let me know if it needs to be pointed another direction or what else I might need to do!

certid_methods.patch View (3.45 KB) Paul Kehrer, 10/18/2012 12:43 PM

certid_methods_v2.patch View (3.37 KB) Paul Kehrer, 10/18/2012 12:51 PM

Associated revisions

Revision 55411
Added by rhe about 1 month ago

openssl: add some accessor methods for OCSP::CertificateId

  • ext/openssl/ossl_ocsp.c (ossl_ocspcid_get_issuer_name_hash,
    ossl_ocspcid_get_issuer_key_hash, ossl_ocspcid_get_hash_algorithm):
    Add accessor methods OCSP::CertificateId#issuer_name_hash,
    #issuer_key_hash, #hash_algorithm.
    Based on a patch provided by Paul Kehrer paul.l.kehrer@gmail.com.
    [Feature #7181]

  • test/openssl/test_ocsp.rb: Test these new methods.

History

#1 [ruby-core:48063] Updated by Paul Kehrer almost 4 years ago

Oops, left one extraneous line in a test. Removed in v2.

#2 [ruby-core:49920] Updated by Yusuke Endoh over 3 years ago

  • Status changed from Open to Assigned
  • Target version set to next minor

#3 [ruby-core:56967] Updated by Paul Kehrer almost 3 years ago

Any chance of this landing in a 2.0.0 patchset?

#4 [ruby-core:57219] Updated by Tomoyuki Chikanaga almost 3 years ago

Hello, reaperhulk.

I'm sorry, it's too late to 2.0.0.
And the feature freeze of 2.1.0 (next minor release) deadline is coming. Please see https://bugs.ruby-lang.org/projects/ruby-trunk/wiki/ReleaseEngineering210 for details.

Martin, could you review the patch?

#5 [ruby-core:57242] Updated by Yui NARUSE almost 3 years ago

  • Target version changed from next minor to 2.1.0

#6 [ruby-core:60266] Updated by Hiroshi SHIBATA over 2 years ago

  • Target version changed from 2.1.0 to current: 2.2.0

#7 Updated by Zachary Scott 11 months ago

  • Assignee changed from Martin Bosslet to openssl

#8 Updated by Anonymous about 1 month ago

  • Status changed from Assigned to Closed

Applied in changeset r55411.


openssl: add some accessor methods for OCSP::CertificateId

  • ext/openssl/ossl_ocsp.c (ossl_ocspcid_get_issuer_name_hash,
    ossl_ocspcid_get_issuer_key_hash, ossl_ocspcid_get_hash_algorithm):
    Add accessor methods OCSP::CertificateId#issuer_name_hash,
    #issuer_key_hash, #hash_algorithm.
    Based on a patch provided by Paul Kehrer paul.l.kehrer@gmail.com.
    [Feature #7181]

  • test/openssl/test_ocsp.rb: Test these new methods.

#9 [ruby-core:76024] Updated by Kazuki Yamaguchi about 1 month ago

Thanks, applied as r55411 with modifications. I made #issuer_{name,key}hash return lowercase strings to match with the return of Digest#hexdigest and renamed #signaturealgorithm to #hash_algorithm because this is not a signature.

Also available in: Atom PDF