Feature #7181: New Methods On OpenSSL::OCSP::CertificateId

• Status: Closed
• Assignee: -
• Target version: -

[reaperhulk (Paul Kehrer)]

This patch adds 3 new methods to OpenSSL::OCSP::CertificateId. These methods are useful when building an OCSP responder or doing comparison without repeatedly calling OpenSSL::OCSP::CertificateId#cmp_issuer

#issuer_name_hash
#issuer_key_hash
#signature_algorithm (returns string representation of alg used just like OpenSSL::X509::Certificate#signature_algorithm or OpenSSL::X509::Request#signature_algorithm)

Martin, I assigned this one to you since you helped me with the last OpenSSL patch I submitted, but let me know if it needs to be pointed another direction or what else I might need to do!

[reaperhulk (Paul Kehrer)]

• File certid_methods_v2.patch certid_methods_v2.patch added

Oops, left one extraneous line in a test. Removed in v2.

[mame (Yusuke Endoh)]

• Status changed from Open to Assigned
• Target version set to 2.6

[reaperhulk (Paul Kehrer)]

Any chance of this landing in a 2.0.0 patchset?

[nagachika (Tomoyuki Chikanaga)]

Hello, reaperhulk.

I'm sorry, it's too late to 2.0.0.
And the feature freeze of 2.1.0 (next minor release) deadline is coming. Please see https://bugs.ruby-lang.org/projects/ruby-trunk/wiki/ReleaseEngineering210 for details.

Martin, could you review the patch?

[naruse (Yui NARUSE)]

• Target version changed from 2.6 to 2.1.0

[hsbt (Hiroshi SHIBATA)]

• Target version changed from 2.1.0 to 2.2.0

[zzak (zzak _)]

• Assignee changed from MartinBosslet (Martin Bosslet) to 7150

• Status changed from Assigned to Closed

Applied in changeset r55411.

---

openssl: add some accessor methods for OCSP::CertificateId

• ext/openssl/ossl_ocsp.c (ossl_ocspcid_get_issuer_name_hash,
  ossl_ocspcid_get_issuer_key_hash, ossl_ocspcid_get_hash_algorithm):
  Add accessor methods OCSP::CertificateId#issuer_name_hash,
  #issuer_key_hash, #hash_algorithm.
  Based on a patch provided by Paul Kehrer [e-mail].
  [ruby-core:48062] [Feature #7181]

• test/openssl/test_ocsp.rb: Test these new methods.

[rhenium (Kazuki Yamaguchi)]

Thanks, applied as r55411 with modifications. I made #issuer_{name,key}_hash return lowercase strings to match with the return of Digest#hexdigest and renamed #signature_algorithm to #hash_algorithm because this is not a signature.