Project

General

Profile

Bug #7216

object.c defines clone method for objects that cannot be cloned.

Added by therevmj (Michael Johnson) almost 7 years ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
all versions up to current trunk
[ruby-core:48292]

Description

As the subject says, in object.c, the clone method is defined and then special cased for certain object types. The end result is that all respond_to?(:clone) returns true for all objects, but then thows an fatal error in some cases. Here is an appropriate example:

a = true
=> true
a.respond_to?(:clone)
=> true
a.clone
TypeError: can't clone TrueClass
from (irb):3:in `clone'
from (irb):3

Ultimately, the objects that do no respond to 'clone' should have it removed so that the respond_to? method returns false.

History

Updated by mame (Yusuke Endoh) almost 7 years ago

  • Status changed from Open to Assigned
  • Assignee set to akr (Akira Tanaka)
  • Target version set to 2.0.0

Akr-san, what do you think?

--
Yusuke Endoh mame@tsg.ne.jp

Updated by akr (Akira Tanaka) almost 7 years ago

2012/11/5 mame (Yusuke Endoh) mame@tsg.ne.jp:

Issue #7216 has been updated by mame (Yusuke Endoh).

Akr-san, what do you think?

It may be good idea.

The root problem is that Liskov substitution principle is violated
between Object and TrueClass.
(Object is clonable but its subclass, TrueClass, is not.)

So, such unprincipled classes may have responsibility to
undefine/unimplement methods which don't work.

I feel it's better to ask matz.
--
Tanaka Akira

Updated by trans (Thomas Sawyer) over 6 years ago

This is true for class method #allocate too.

Updated by mame (Yusuke Endoh) over 6 years ago

  • Assignee changed from akr (Akira Tanaka) to matz (Yukihiro Matsumoto)
  • Target version changed from 2.0.0 to 2.6
#5

Updated by naruse (Yui NARUSE) over 1 year ago

  • Target version deleted (2.6)

Updated by jeremyevans0 (Jeremy Evans) about 2 months ago

  • Status changed from Assigned to Closed

Ruby started allowing clone on immediate values (true, false, nil, symbol, integer, float) in Ruby 2.4:

$ ruby23 -e 'p true.clone'
-e:1:in `clone': can't clone TrueClass (TypeError)
        from -e:1:in `<main>'
$ ruby24 -e 'p true.clone'
true

Also available in: Atom PDF