Feature #7654: Add optional code block to IO::readlines

• Status: Assigned
• Assignee: matz (Yukihiro Matsumoto)
• Target version: -

[shock_one (Володимир Шацький)]

Of course, we always can write something like
File.readlines('/home/shock_one/test.rb').map{ |line| line.upcase }
but this way we create unneeded intermediate array which can be pretty big.
There is also a method IO::foreach, but it doesn't collect return values.
Besides it seems pretty logical and natural to have a block in this method.

[shock_one (Володимир Шацький)]

Just to be clear: code block will allow to write the first code snippet as follows:
data = File.readlines('/home/shock_one/test.rb'){ |line| line.upcase }

[Eregon (Benoit Daloze)]

Why not

File.foreach('test.rb').map { |line| line.upcase }

?
It does not create an intermediary Array.
If you need to do other operations lazily (without an intermediate result), you could use #lazy:

File.foreach('test.rb').lazy.select { |line| line.start_with? '/' }.map { |line| line.upcase }.to_a

[Eregon (Benoit Daloze)]

But of course the main memory usage here are likely String instances, so you could update them in place if possible:

File.foreach('test.rb').map { |line| line.upcase!; line }
# or
lines = File.readlines('test.rb')
lines.each(&:upcase!)

[Eregon (Benoit Daloze)]

(There is also Array#map!)

[shock_one (Володимир Шацький)]

Thank you, Eregon, especially for in place methods. I should definitely pay more attention to them - functional languages made me a little suspicious of this sort of things.
But I still think it would be nice to have an optional block in IO::readlines, at least for convenience. Enumerable#grep has similar behavior and I find it really cool and useful. Also this change doesn't break anything, is easy to implement and makes the code more concise.

[ko1 (Koichi Sasada)]

next minor issue or 2.0.0 issue?

[drbrain (Eric Hodel)]

I think next minor. It is a new feature but trunk is closed for new features.

[drbrain (Eric Hodel)]

• Target version set to 2.6

[ko1 (Koichi Sasada)]

• Assignee set to matz (Yukihiro Matsumoto)

[naruse (Yui NARUSE)]

• Target version deleted (2.6)

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Assigned