Bug #7940: Mistaken use of inline rescues in stdlib

• Status: Closed
• Assignee: dblack (David Black)
• Target version: 2.1.0
• ruby -v: ruby 1.9.3p392 (2013-02-22 revision 39386) [x86_64-linux]

[Mon_Ouie (Mon ouïe)]

Hey,

There are two uses of inline rescues in stdlib that look dubious. They are unlikely to ever cause any harm, but still. They've been there for a while now, and are still in trunk. I attached a patch that changes both of them.

In cgi/session.rb:

  def delete
    File::unlink @path+".lock" rescue nil
    File::unlink @path+".new" rescue nil
    File::unlink @path rescue Errno::ENOENT
  end

The rescue part should be on the next line (this has been introduced in a commit that changed indentation).

In scanf.rb:660:

seek(start_position + matched_so_far, IO::SEEK_SET) rescue Errno::ESPIPE

was more likely meant to just silence Errno::ESPIPE exceptions.

[drbrain (Eric Hodel)]

• Assignee set to xibbar (Takeyuki FUJIOKA)
• Priority changed from 3 to Normal
• Target version set to 2.1.0

[drbrain (Eric Hodel)]

• Status changed from Open to Assigned

[xibbar (Takeyuki FUJIOKA)]

I am maintainer of cgi* but not maintainer of lib/scanf.rb

May I commit with lib/scanf.rb ?

[naruse (Yui NARUSE)]

xibbar (Takeyuki FUJIOKA) wrote:

I am maintainer of cgi* but not maintainer of lib/scanf.rb

May I commit with lib/scanf.rb ?

Commit your part and assign this to dblack.

[xibbar (Takeyuki FUJIOKA)]

Sorry I was misunderstanding that lib/scanf.rb does not have a maintainer.

[xibbar (Takeyuki FUJIOKA)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r40367.
Mon, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• lib/cgi/session.rb: update rescue in delete session file
  only Errno::ENOENT.[Bug #7940]

[xibbar (Takeyuki FUJIOKA)]

• Status changed from Closed to Assigned
• Assignee changed from xibbar (Takeyuki FUJIOKA) to dblack (David Black)

update only my part.
please consider your part > dblack.

[xibbar (Takeyuki FUJIOKA)]

• % Done changed from 100 to 50

[Eregon (Benoit Daloze)]

Related issue for the C counterpart: #7688.

[zzak (zzak _)]

I've tweeted @david_a_black asking him to check this ticket.

He has been inactive for a long time, though.

Bump.

Should dblack be discharged under the 3 month rule? He has not been active for quite some time.

[nobu (Nobuyoshi Nakada)]

• Status changed from Assigned to Closed
• % Done changed from 50 to 100

This issue was solved with changeset r44196.
Mon, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

scanf.rb: fix rescue modifier

• lib/scanf.rb (IO#scanf): fix mistaken use of rescue modifier.
  a patch by Mon_Ouie at [ruby-core:52813]. [Bug #7940]