Feature #8461

Easy way to disable certificate checking in XMLRPC::Client

Added by Herwin . 11 months ago. Updated 10 months ago.

[ruby-core:55197]
Status:Closed
Priority:Low
Assignee:Kouhei Sutou
Category:lib
Target version:-

Description

I have an awful lot of XMLRPC code that does the following:

c = XMLRPC::Client.new(....)
c.instancevariableget(:@http).instancevariableset(:@verifymode, OpenSSL::SSL::VERIFYNONE)

It would be nice if some syntactic sugar would be added so I could just do something like this:

c.setsslverifymode(OpenSSL::SSL::VERIFYNONE)

Associated revisions

Revision 41286
Added by Kouhei Sutou 10 months ago

  • lib/xmlrpc/client.rb (XMLRPC::Client#http): Add reader for raw Net::HTTP. [Feature #8461] Reported by Herwin Weststrate. Thanks!!!

Revision 41329
Added by Kouhei Sutou 10 months ago

  • NEWS (XMLRPC::Client#http): Add. [Feature #8461]

History

#1 Updated by Zachary Scott 11 months ago

  • Category set to lib
  • Status changed from Open to Assigned
  • Assignee set to Kouhei Sutou

#2 Updated by Kouhei Sutou 11 months ago

It seems that lib/xmlrpc/ doesn't have maintainer. (cf. https://bugs.ruby-lang.org/projects/ruby/wiki/Maintainers )
So I'm not a maintainer of lib/xmlrpc/. I don't know why I was assigned this ticket. (I think zzak mistook. :-)

By the way, I can become a maintainer of lib/xmlrpc/ If nobody objects it, I will handle this ticket.

#3 Updated by Zachary Scott 11 months ago

Whoops! :+1:

On Mon, Jun 3, 2013 at 10:13 AM, kou (Kouhei Sutou) kou@cozmixng.org wrote:

Issue #8461 has been updated by kou (Kouhei Sutou).

It seems that lib/xmlrpc/ doesn't have maintainer. (cf. https://bugs.ruby-lang.org/projects/ruby/wiki/Maintainers )
So I'm not a maintainer of lib/xmlrpc/. I don't know why I was assigned this ticket. (I think zzak mistook. :-)

By the way, I can become a maintainer of lib/xmlrpc/ If nobody objects it, I will handle this ticket.


Feature #8461: Easy way to disable certificate checking in XMLRPC::Client
https://bugs.ruby-lang.org/issues/8461#change-39657

Author: herwinw (Herwin Weststrate)
Status: Assigned
Priority: Low
Assignee: kou (Kouhei Sutou)
Category: lib
Target version:

I have an awful lot of XMLRPC code that does the following:

c = XMLRPC::Client.new(....)
c.instancevariableget(:@http).instancevariableset(:@verifymode, OpenSSL::SSL::VERIFYNONE)

It would be nice if some syntactic sugar would be added so I could just do something like this:

c.setsslverifymode(OpenSSL::SSL::VERIFYNONE)

http://bugs.ruby-lang.org/

#4 Updated by Koichi Sasada 11 months ago

(2013/06/03 10:13), kou (Kouhei Sutou) wrote:

By the way, I can become a maintainer of lib/xmlrpc/ If nobody objects it, I will handle this ticket.

Great!

--
// SASADA Koichi at atdot dot net

#5 Updated by Yukihiro Matsumoto 11 months ago

The new maintainer accepted.

Matz.

#6 Updated by Kouhei Sutou 11 months ago

Thanks for accepting it.
I'll check this and other XMLRPC related tickets. (I go traveling in this week.)

#7 Updated by Kouhei Sutou 10 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r41286.
Herwin, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/xmlrpc/client.rb (XMLRPC::Client#http): Add reader for raw Net::HTTP. [Feature #8461] Reported by Herwin Weststrate. Thanks!!!

#8 Updated by Kouhei Sutou 10 months ago

I've added XMLRPC::Client#http. Use it like:

c = XMLRPC::Client.new(....)
c.http.verifymode = OpenSSL::SSL::VERIFYNONE

#9 Updated by Yui NARUSE 10 months ago

  • Status changed from Closed to Assigned

kou (Kouhei Sutou) wrote:

I've added XMLRPC::Client#http. Use it like:

c = XMLRPC::Client.new(....)
c.http.verifymode = OpenSSL::SSL::VERIFYNONE

Could you edit NEWS to introduce the new feature?

#10 Updated by Zachary Scott 10 months ago

Hello,

On Fri, Jun 14, 2013 at 12:06 AM, naruse (Yui NARUSE) naruse@airemix.jp wrote:

Could you edit NEWS to introduce the new feature?

+1

#11 Updated by Kouhei Sutou 10 months ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r41329.
Herwin, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • NEWS (XMLRPC::Client#http): Add. [Feature #8461]

#12 Updated by Kouhei Sutou 10 months ago

Done.

Also available in: Atom PDF