Bug #8621

MinGW: Rational tests are causing error

Added by Luis Lavena 9 months ago. Updated 3 months ago.

[ruby-core:55923]
Status:Assigned
Priority:Normal
Assignee:Nobuyoshi Nakada
Category:test
Target version:current: 2.2.0
ruby -v:trunk r41900 Backport:1.9.3: UNKNOWN, 2.0.0: UNKNOWN

Description

Hello,

It seems that Rational related tests are causing failure in RubyInstaller CI:

http://ci.rubyinstaller.org/job/ruby-trunk-x86-test-all/1772/console

ComplexRationalTest#testcompsrat = 0.00 s = .
ComplexRational
Test#testratsrat = make: *** [yes-test-all] Error 253

There is no backtrace or anything, but it has been failing over the last couple of builds repeatedly.

Associated revisions

Revision 41923
Added by Nobuyoshi Nakada 9 months ago

win32.c: fix infinite recursion

  • win32/win32.c (rbw32pow): undef pow to get rid of infinite recursive call. re-fix [Bug #8495]. [Bug #8621]

History

#1 Updated by Heesob Park 9 months ago

This issue is raise from pow function failure of float on mingw-w64 x86.

C:\work>irb
irb(main):001:0> 1 ** 2
=> 1
irb(main):002:0> 1.0 ** 2.0

C:\work>

Exited without return value or exception.

I found that this failure is due to r41836.

The pow call is causing infinite self calling.
The macro "#define pow rbw32pow" in win32.h
and rb32pow function calls pow again in win32.c

I think the r41836 should be reverted.

#2 Updated by Nobuyoshi Nakada 9 months ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r41923.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


win32.c: fix infinite recursion

  • win32/win32.c (rbw32pow): undef pow to get rid of infinite recursive call. re-fix [Bug #8495]. [Bug #8621]

#3 Updated by Luis Lavena 9 months ago

  • Status changed from Closed to Assigned
  • Assignee changed from tadayoshi funaba to Nobuyoshi Nakada
  • % Done changed from 100 to 50

=begin
Thank you nobu, but seems we are back to the floating error again:

http://ci.rubyinstaller.org/job/ruby-trunk-x86-test-all/1784/console

1) Failure:
TestSprintf#testfloat [C:/Users/Worker/Jenkins/workspace/ruby-trunk-x86-build/test/ruby/testsprintf.rb:193]:
.
<"0x1p+2"> expected but was
<"0x1p+1">.
=end

#4 Updated by Hiroshi SHIBATA 3 months ago

  • Target version changed from 2.1.0 to current: 2.2.0

Also available in: Atom PDF