Project

General

Profile

Bug #8623

Make stable Gem::Specification.files in default .gemspecs

Added by vo.x (Vit Ondruch) over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 2.0.0p195 (2013-05-14 revision 40734) [x86_64-linux]
[ruby-core:55946]

Description

Although the .gemspec files for default gems are same in function, the different order of their "s.files" makes them different therefore possibly conflicting in multilib scenario. Simple sorting fixes this issue.

ruby-2.0.0-p247-Make-stable-Gem-Specification.files-in-default-.gems.patch View (831 Bytes) vo.x (Vit Ondruch), 10/01/2013 07:59 PM

Associated revisions

Revision 43587
Added by nobu (Nobuyoshi Nakada) over 3 years ago

rbinstall.rb: make stable files in .gemspec

  • tool/rbinstall.rb (Gem::Specification#collect): make stable Gem::Specification.files in default .gemspecs the different order of "files" in .gemspec files makes them different therefore possibly conflicting in multilib scenario. patch by vo.x (Vit Ondruch) at [Bug #8623].

Revision 43587
Added by nobu (Nobuyoshi Nakada) over 3 years ago

rbinstall.rb: make stable files in .gemspec

  • tool/rbinstall.rb (Gem::Specification#collect): make stable Gem::Specification.files in default .gemspecs the different order of "files" in .gemspec files makes them different therefore possibly conflicting in multilib scenario. patch by vo.x (Vit Ondruch) at [Bug #8623].

Revision 43587
Added by nobu (Nobuyoshi Nakada) over 3 years ago

rbinstall.rb: make stable files in .gemspec

  • tool/rbinstall.rb (Gem::Specification#collect): make stable Gem::Specification.files in default .gemspecs the different order of "files" in .gemspec files makes them different therefore possibly conflicting in multilib scenario. patch by vo.x (Vit Ondruch) at [Bug #8623].

Revision 43587
Added by nobu (Nobuyoshi Nakada) over 3 years ago

rbinstall.rb: make stable files in .gemspec

  • tool/rbinstall.rb (Gem::Specification#collect): make stable Gem::Specification.files in default .gemspecs the different order of "files" in .gemspec files makes them different therefore possibly conflicting in multilib scenario. patch by vo.x (Vit Ondruch) at [Bug #8623].

History

#1 [ruby-core:55947] Updated by naruse (Yui NARUSE) over 3 years ago

  • Status changed from Open to Assigned
  • Assignee set to drbrain (Eric Hodel)
  • Category set to lib

#2 [ruby-core:57544] Updated by vo.x (Vit Ondruch) over 3 years ago

Not sure why I did not attached patch, so here it is.

#3 Updated by nobu (Nobuyoshi Nakada) over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Closed

This issue was solved with changeset r43587.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


rbinstall.rb: make stable files in .gemspec

  • tool/rbinstall.rb (Gem::Specification#collect): make stable Gem::Specification.files in default .gemspecs the different order of "files" in .gemspec files makes them different therefore possibly conflicting in multilib scenario. patch by vo.x (Vit Ondruch) at [Bug #8623].

#4 [ruby-core:58576] Updated by nagachika (Tomoyuki Chikanaga) over 3 years ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 1.9.3: UNKNOWN, 2.0.0: REQUIRED

I've overlooked this ticket.

Hello vit, r43587 should be backported to ruby_2_0_0, doesn't it?

#5 [ruby-core:58596] Updated by vo.x (Vit Ondruch) over 3 years ago

nagachika (Tomoyuki Chikanaga) wrote:

I've overlooked this ticket.

Hello vit, r43587 should be backported to ruby_2_0_0, doesn't it?

That would be sweet if you can backport. One less patch I need to maintain for Fedora.

#6 Updated by nagachika (Tomoyuki Chikanaga) about 3 years ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: REQUIRED to 1.9.3: UNKNOWN, 2.0.0: DONE

r43587 was backported to ruby_2_0_0 at r44567.

#7 [ruby-core:60482] Updated by usa (Usaku NAKAMURA) about 3 years ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: DONE to 1.9.3: DONTNEED, 2.0.0: DONE

Also available in: Atom PDF