Project

General

Profile

Actions

Bug #9276

closed

"RUBY_FREE_MIN is obsolete. Use RUBY_GC_HEAP_FREE_SLOTS instead" warning should not be issued when both ENV vars are set.

Added by myronmarston (Myron Marston) almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Target version:
ruby -v:
ruby 2.1.0dev (2013-12-20 trunk 44301) [x86_64-darwin12.0]
[ruby-core:59255]

Description

Trying out ruby 2.1.0-rc1, I keep getting this warning. I understand why, and I've updated my ~/.zshrc to set RUBY_GC_HEAP_FREE_SLOTS for ruby 2.1, but I need to keep RUBY_GC_HEAP_FREE_SLOTS set for projects running on earlier versions. Ideally, this warning would only be emitted when RUBY_FREE_MIN is set and RUBY_GC_HEAP_FREE_SLOTS is not set. If RUBY_GC_HEAP_FREE_SLOTS is set, the programmer clearly knows that's the ENV var to use for 2.1, and likely needs to keep RUBY_FREE_MIN in place for running code against older rubies. After all, having RUBY_FREE_MIN set on 2.1 doesn't cause any problems, right?

Actions #1

Updated by ko1 (Koichi Sasada) almost 11 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r44327.
Myron, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • gc.c (ruby_gc_set_params): don't show obsolete warnings for
    RUBY_FREE_MIN/RUBY_HEAP_MIN_SLOTS if
    RUBY_GC_HEAP_FREE_SLOTS/RUBY_GC_HEAP_INIT_SLOTS are given.
    [Bug #9276]

Updated by ko1 (Koichi Sasada) almost 11 years ago

  • Category set to core
  • Status changed from Closed to Assigned
  • Assignee set to naruse (Yui NARUSE)

I think this request is reasonable.

myronmarston:
could you check the behavior of trunk?

Naruse-san:
could you decide to introduce this patch or not?

Updated by myronmarston (Myron Marston) almost 11 years ago

could you check the behavior of trunk?

Is there an easy way to build trunk using chruby? That's what I use these days to install my rubies. I haven't played around with setting up an MRI dev environment at all.

Updated by Eregon (Benoit Daloze) almost 11 years ago

myronmarston (Myron Marston) wrote:

Is there an easy way to build trunk using chruby? That's what I use these days to install my rubies. I haven't played around with setting up an MRI dev environment at all.

It does not seems to be. Although it might be worth to add an issue to ruby-install about that.
It should be as simple as:

$ wget https://ftp.ruby-lang.org/pub/ruby/snapshot.tar.gz
$ tar xf snapshot.tar.gz
$ cd ruby-*
$ mkdir build
$ ./configure --prefix=pwd/build
$ make install
$ ./build/bin/ruby -v

Updated by naruse (Yui NARUSE) almost 11 years ago

ko1 (Koichi Sasada) wrote:

Naruse-san:
could you decide to introduce this patch or not?

It sounds reasonable but will be 2.1.1.

myronmarston (Myron Marston) wrote:

could you check the behavior of trunk?

Is there an easy way to build trunk using chruby? That's what I use these days to install my rubies. I haven't played around with setting up an MRI dev environment at all.

What you need sound rbenv.
http://rbenv.org/

Updated by postmodern (Hal Brodigan) almost 11 years ago

It appears MRI builds the ruby executable in the root of trunk, not in the bin/ directory where chruby expects it to be. Until this is fixed, you will have to install trunk somewhere (~/.rubies/ or append the installation dir to RUBIES).

Updated by hsbt (Hiroshi SHIBATA) almost 11 years ago

  • Target version changed from 2.1.0 to 2.2.0

Updated by tmm1 (Aman Karmani) almost 11 years ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN to 1.9.3: DONTNEED, 2.0.0: DONTNEED, 2.1: REQUIRED

Updated by naruse (Yui NARUSE) almost 11 years ago

  • Status changed from Assigned to Closed

Updated by naruse (Yui NARUSE) almost 11 years ago

  • Backport changed from 1.9.3: DONTNEED, 2.0.0: DONTNEED, 2.1: REQUIRED to 1.9.3: DONTNEED, 2.0.0: DONTNEED, 2.1: DONE

ruby_2_1 r45054 merged revision(s) 44327.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0