Bug #9430

[PATCH] benchmark/driver: avoid large alloc in driver process

Added by Eric Wong about 1 year ago. Updated about 1 year ago.

[ruby-core:59869]
Status:Closed
Priority:Normal
Assignee:Nobuyoshi Nakada
ruby -v:trunk Backport:1.9.3: DONE, 2.0.0: DONE, 2.1: DONE

Description

Using backtick to capture output on bm_so_reverse_complement leads
to unpredictable results because the Ruby process capturing needs to
slurp the 25M output of that benchmark, meaning the GC run of the
driver process ends up bottlenecking the processes being
benchmarked.

Instead, just redirect to File::NULL which is /dev/null on Unix-like
systems.


The following changes since commit 41bdefd56f628781a19f5d5d5f6a9a05cb4f3e9e:

tracepoint.c: disable tracepoint (2014-01-19 08:56:58 +0000)

are available in the git repository at:

git://80x24.org/ruby.git benchdriver-system

for you to fetch changes up to c4ac0560c88e45e026fdfaa313b6417458da53ce:

benchmark/driver: avoid large alloc in driver process (2014-01-19 10:34:47 +0000)


Eric Wong (1):
benchmark/driver: avoid large alloc in driver process

benchmark/driver.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

0001-benchmark-driver-avoid-large-alloc-in-driver-process.patch Magnifier (1002 Bytes) Eric Wong, 01/19/2014 10:41 AM

Associated revisions

Revision 44772
Added by normal about 1 year ago

benchmark/driver: avoid large alloc in driver process

  • benchmark/driver: avoid large alloc in driver process [Bug #9430]

Revision 44772
Added by normal about 1 year ago

benchmark/driver: avoid large alloc in driver process

  • benchmark/driver: avoid large alloc in driver process [Bug #9430]

History

#1 Updated by Eric Wong about 1 year ago

Btw, I'll commit soon unless there's objections, this is pretty trivial:

 * benchmark/driver: avoid large alloc in driver process
    [Bug #9430]

#2 Updated by Koichi Sasada about 1 year ago

Sure.

#3 Updated by Anonymous about 1 year ago

  • % Done changed from 0 to 100
  • Status changed from Open to Closed

Applied in changeset r44772.


benchmark/driver: avoid large alloc in driver process

  • benchmark/driver: avoid large alloc in driver process [Bug #9430]

#4 Updated by Eric Wong about 1 year ago

#5 Updated by Usaku NAKAMURA about 1 year ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN to 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED

#6 Updated by Usaku NAKAMURA about 1 year ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: DONE, 2.0.0: REQUIRED, 2.1: REQUIRED

backported into ruby_1_9_3 at r44942.

#7 Updated by Tomoyuki Chikanaga about 1 year ago

  • Backport changed from 1.9.3: DONE, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: DONE, 2.0.0: DONE, 2.1: REQUIRED

r44772 was backported to ruby_2_0_0 at r45007.

#8 Updated by Yui NARUSE about 1 year ago

  • Backport changed from 1.9.3: DONE, 2.0.0: DONE, 2.1: REQUIRED to 1.9.3: DONE, 2.0.0: DONE, 2.1: DONE

r45121

Also available in: Atom PDF