Project

General

Profile

Actions

Bug #16427

closed

Revert did_you_mean promotion to default gem.

Added by vo.x (Vit Ondruch) over 4 years ago. Updated over 4 years ago.

Status:
Rejected
Target version:
-
ruby -v:
ruby 2.7.0dev (2019-12-10 master af11efd377) [x86_64-linux]
[ruby-core:96286]

Description

One of the points made in #16363 was:

so we can always reliably require it whenever we want to.

That is not true anymore, because did_you_mean is always required when RubyGems are enabled since 1:

$ ruby -e 'puts $LOADED_FEATURES' | grep did

Removing all traces of did_you_mean from my system only results in:

$ ruby -e 'puts $LOADED_FEATURES' | grep did
Traceback (most recent call last):
	2: from <internal:gem_prelude>:2:in `<internal:gem_prelude>'
	1: from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:92:in `require'
/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:92:in `require': cannot load such file -- did_you_mean (LoadError)

just confirming what I said above.

IMO, did_you_mean gem might be useful for development, but should not be required for runtime at all. On one hand there are taken steps to improve Ruby speed, but this is going contrary to that goal.


Related issues 2 (0 open2 closed)

Related to Ruby master - Feature #16363: Promote did_you_mean to default gemClosedyuki24 (Yuki Nishijima)Actions
Related to Ruby master - Feature #16431: Optionally load did_you_mean (and RubyGems)Closedhsbt (Hiroshi SHIBATA)Actions
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0Like0