Bug #3320

Feature #5142: Remove ruby-mode.el from ruby's repo

emacs ruby-mode.el font-lock fails on symboled string ending with ?

Added by Zev Blut almost 4 years ago. Updated over 1 year ago.

[ruby-core:30315]
Status:Third Party's Issue
Priority:Normal
Assignee:Nobuyoshi Nakada
Category:-
Target version:1.9.4
ruby -v:1.9.2 (trunk and 1.8.7)+ Backport:

Description

=begin
Fontification breaks when emacs sees a symbol like
:'this is a symbol?'

example code:


class EmacsExample
:symbol

'this is a test'
'is this a test?'
"Can this be a test"
:'this is an error?'

def bar
@help
end
end


I have a very hacked fix in ruby-font-lock-syntactic-keywords
for
;; the last $', $", $in the respective string is not variable
;; the last ?', ?", ?
in the respective string is not ascii code
("\(\|[[ \t\n<+(,=:]\)\(['\"]\\)\\(\\\\.\\|\\2\\|[^'\"\n\\]\)*?\\?[?$]\(\2\)"
(2 (7 . nil))
(4 (7 . nil)))

by adding : in the above matches with space tabs L etc...

See the attached patch

I am not sure this is the proper fix, but it fixes the above example.

Thanks,
Zev
=end

ruby-mode.el.patch Magnifier (1.63 KB) Zev Blut, 05/20/2010 12:21 AM


Related issues

Related to ruby-trunk - Feature #6823: Where/how should ruby-mode issues be reported? Assigned
Duplicated by ruby-trunk - Bug #4398: Highlighting of "'?" in Emacs Third Party's Issue 02/15/2011

History

#1 Updated by Zev Blut almost 4 years ago

=begin

=end

#2 Updated by Zev Blut almost 4 years ago

=begin
I found another related parse error. Unfortunately, I am not sure how to fix this one.

This is a multi line string that starts on one line and ends on a different line with a ?
Such as:


x = 'What do you think about this long
text today ?'

def foo
end


=end

#3 Updated by Ryan Davis almost 4 years ago

=begin

On May 20, 2010, at 06:18 , Zev Blut wrote:

Issue #3320 has been updated by Zev Blut.

I found another related parse error. Unfortunately, I am not sure how to fix this one.

This is a multi line string that starts on one line and ends on a different line with a ?

Such as:

x = 'What do you think about this long
text today ?'

def foo
end

In this case it is because it sees ?' or ?" and interprets that as the character notation (I have no idea what this is called). Putting a backslash in front of the ? fixes the problem locally.

There are a lot of different things that can trip up ruby-mode when inside a string. I tripped on one today with a multiline string with "def" in it:

eval "
def xxx
yyy
end
"

Notice that tab will indent up to the yyy as if it is actual code, not string content.

BTW, I'm using version 1.0 of ruby-mode.el as supplied in emacs 24.0.50. It may be more up to date in the ruby distro, but afaik, it should be shifting to emacs for distribution.

=end

#4 Updated by Akira Tanaka almost 3 years ago

  • Project changed from Ruby to ruby-trunk
  • Category deleted (misc)
  • Assignee set to Nobuyoshi Nakada

#5 Updated by Hiroshi Nakamura almost 3 years ago

  • Target version set to 1.9.3

#6 Updated by Motohiro KOSAKI almost 3 years ago

  • Status changed from Open to Assigned

#7 Updated by Motohiro KOSAKI over 2 years ago

  • Target version changed from 1.9.3 to 1.9.4

ETIMEOUT. ruby-mode.el never be release stopper.

#8 Updated by Yui NARUSE over 2 years ago

  • Parent task set to #5142

#9 Updated by Dmitry Gutov over 1 year ago

All examples in this bug work fine for me with ruby-mode from the Emacs tree.
Not sure when they were fixed.

#10 Updated by Nobuyoshi Nakada over 1 year ago

  • Status changed from Assigned to Third Party's Issue

Also available in: Atom PDF