Project

General

Profile

Actions

Bug #883

closed

Failure: test_handle_special_CROSSREF_no_underscore(TestRDocMarkupToHtmlCrossref)

Added by znz (Kazuhiro NISHIYAMA) over 15 years ago. Updated almost 13 years ago.

Status:
Closed
Target version:
ruby -v:
ruby 1.9.1 (2008-12-15 revision 20750) [i686-linux]
Backport:
[ruby-core:20564]

Description

=begin
test failed with full path

% ruby-trunk -v
ruby 1.9.1 (2008-12-15 revision 20750) [i686-linux]
% ruby-trunk test/rdoc/test_rdoc_markup_to_html_crossref.rb
nil
Loaded suite test/rdoc/test_rdoc_markup_to_html_crossref
Started
.
Finished in 0.153602 seconds.

1 tests, 210 assertions, 0 failures, 0 errors, 0 skips
% ruby-trunk $(pwd)/test/rdoc/test_rdoc_markup_to_html_crossref.rb
nil
Loaded suite /home/kazu/wc/ruby-lang/trunk/test/rdoc/test_rdoc_markup_to_html_crossref
Started
F
Finished in 0.041989 seconds.

  1. Failure:
    test_handle_special_CROSSREF_no_underscore(TestRDocMarkupToHtmlCrossref) [/home/kazu/wc/ruby-lang/trunk/test/rdoc/test_rdoc_markup_to_html_crossref.rb:87]:
    Expected "

    <a href="../files/home/kazu/wc/ruby-lang/trunk/test/rdoc/rdoc_markup_to_html_crossref_reference_rb.html">/home/kazu/wc/ruby-lang/trunk/test/rdoc/rdoc_markup_to_html_crossref_reference.rb

    ", not "

    /home/kazu/wc/ruby-lang/trunk/test/rdoc/rdoc_markup_to_html_crossref_reference.rb

    ".

1 tests, 29 assertions, 1 failures, 0 errors, 0 skips
%
=end


Related issues 2 (0 open2 closed)

Related to Ruby master - Bug #2066: Merge Latest RDoc/RiCloseddrbrain (Eric Hodel)09/09/2009Actions
Related to Ruby master - Feature #2635: Unbundle rdocRejectedmatz (Yukihiro Matsumoto)01/23/2010Actions
Actions #1

Updated by drbrain (Eric Hodel) over 15 years ago

  • Category set to lib
  • Assignee set to drbrain (Eric Hodel)

=begin
I cannot reproduce:

$ ruby19 -v
ruby 1.9.1 (2008-12-16 revision 20769) [i386-darwin9.5.0]

$ ruby19 test/rdoc/test_rdoc_markup_to_html_crossref.rb
nil
Loaded suite test/rdoc/test_rdoc_markup_to_html_crossref
Started
.
Finished in 0.078531 seconds.

1 tests, 210 assertions, 0 failures, 0 errors, 0 skips

$ ruby19 $(pwd)/test/rdoc/test_rdoc_markup_to_html_crossref.rb
nil
Loaded suite /Users/drbrain/Work/svn/ruby/trunk/test/rdoc/test_rdoc_markup_to_html_crossref
Started
.
Finished in 0.081387 seconds.

1 tests, 210 assertions, 0 failures, 0 errors, 0 skips

also, test-all passes for this test:

$ make test-all TESTS=rdoc/test_rdoc_markup_to_html_crossref.rb
./miniruby -I./lib -I.ext/common -I./- -r./ext/purelib.rb ./runruby.rb --extout=.ext -- "./test/runner.rb" rdoc/test_rdoc_markup_to_html_crossref.rb
nil
Loaded suite ./test/runner
Started
.
Finished in 0.086197 seconds.

1 tests, 210 assertions, 0 failures, 0 errors, 0 skips

=end

Actions #2

Updated by znz (Kazuhiro NISHIYAMA) over 15 years ago

=begin
another failure example:

% cd test
% ruby-trunk ../test/rdoc/test_rdoc_markup_to_html_crossref.rb
nil
Loaded suite ../test/rdoc/test_rdoc_markup_to_html_crossref
Started
F
Finished in 0.058379 seconds.

  1. Failure:
    test_handle_special_CROSSREF_no_underscore(TestRDocMarkupToHtmlCrossref) [../test/rdoc/test_rdoc_markup_to_html_crossref.rb:87]:
    Expected "

    <a href="../files/__/test/rdoc/rdoc_markup_to_html_crossref_reference_rb.html">../test/rdoc/rdoc_markup_to_html_crossref_reference.rb

    ", not "

    ../test/rdoc/rdoc_markup_to_html_crossref_reference.rb

    ".

1 tests, 29 assertions, 1 failures, 0 errors, 0 skips
%
=end

Actions #3

Updated by candlerb (Brian Candler) over 15 years ago

=begin

I cannot reproduce:

I can reproduce here (Ubuntu Hardy)

ruby-1.9.1-preview2$ ruby19 -v
ruby 1.9.1 (2008-12-01 revision 20438) [i686-linux]

ruby-1.9.1-preview2$ ruby19 $(pwd)/test/rdoc/test_rdoc_markup_to_html_crossref.rb
Loaded suite /v/build/ruby-1.9.1-preview2/test/rdoc/test_rdoc_markup_to_html_crossref
Started
F
Finished in 0.046547 seconds.

  1. Failure:
    test_handle_special_CROSSREF_no_underscore(TestRDocMarkupToHtmlCrossref) [/v/build/ruby-1.9.1-preview2/test/rdoc/test_rdoc_markup_to_html_crossref.rb:87]:
    Expected "

    <a href="../files/v/build/ruby-1_9_1-preview2/test/rdoc/rdoc_markup_to_html_crossref_reference_rb.html">/v/build/ruby-1.9.1-preview2/test/rdoc/rdoc_markup_to_html_crossref_reference.rb

    ", not "

    /v/build/ruby-1.9.1-preview2/test/rdoc/rdoc_markup_to_html_crossref_reference.rb

    ".

1 tests, 29 assertions, 1 failures, 0 errors, 0 skips

And here's on another Hardy machine running trunk from yesterday:

ruby-svn$ ruby19 -v
ruby 1.9.1 (2008-12-16 revision 20768) [i686-linux]
brian@mappit:/v/downloads/ruby-svn$ ruby19 test/rdoc/test_rdoc_markup_to_html_crossref.rb
nil
Loaded suite test/rdoc/test_rdoc_markup_to_html_crossref
Started
.
Finished in 0.528887 seconds.

1 tests, 210 assertions, 0 failures, 0 errors, 0 skips
ruby-svn$ ruby19 $(pwd)/test/rdoc/test_rdoc_markup_to_html_crossref.rb
nil
Loaded suite /v/downloads/ruby-svn/test/rdoc/test_rdoc_markup_to_html_crossref
Started
F
Finished in 0.089370 seconds.

  1. Failure:
    test_handle_special_CROSSREF_no_underscore(TestRDocMarkupToHtmlCrossref) [/v/downloads/ruby-svn/test/rdoc/test_rdoc_markup_to_html_crossref.rb:87]:
    Expected "

    <a href="../files/v/downloads/ruby-svn/test/rdoc/rdoc_markup_to_html_crossref_reference_rb.html">/v/downloads/ruby-svn/test/rdoc/rdoc_markup_to_html_crossref_reference.rb

    ", not "

    /v/downloads/ruby-svn/test/rdoc/rdoc_markup_to_html_crossref_reference.rb

    ".

1 tests, 29 assertions, 1 failures, 0 errors, 0 skips

=end

Actions #4

Updated by znz (Kazuhiro NISHIYAMA) about 15 years ago

  • ruby -v set to ruby 1.9.1 (2008-12-15 revision 20750) [i686-linux]

=begin
reported in [ruby-dev:37919], failed when path of source tree includes '-'.
=end

Actions #5

Updated by nagachika (Tomoyuki Chikanaga) about 15 years ago

=begin
I've found that test/rdoc/test_rdoc_markup_to_html_crossref.rb fails when full-path of source tree
contains '-', like "/usr/local/src/ruby-trunk/".

I have a tiny patch solves this test failure.
I'm not confident it's right way to fix the problem. Please examine it.

===================================================================
--- lib/rdoc/markup/to_html_crossref.rb (revision 22068)
+++ lib/rdoc/markup/to_html_crossref.rb (working copy)
@@ -65,7 +65,7 @@
# The key thing is that there must be at least
# one special character (period, slash, or
# underscore).

  •                  | [\/\w]+[_\/\.][\w\/\.]+
    
  •                  | [-\/\w]+[_\/\.][-\w\/\.]+
    
                     # Things that have markup suppressed
                     | \\[^\s]
    

=end

Actions #6

Updated by nobu (Nobuyoshi Nakada) about 15 years ago

=begin
Hi,

At Wed, 17 Dec 2008 00:30:45 +0900,
Kazuhiro NISHIYAMA wrote in [ruby-core:20599]:

another failure example:

% cd test
% ruby-trunk ../test/rdoc/test_rdoc_markup_to_html_crossref.rb
nil
Loaded suite ../test/rdoc/test_rdoc_markup_to_html_crossref
Started
F
Finished in 0.058379 seconds.

  1. Failure:
    test_handle_special_CROSSREF_no_underscore(TestRDocMarkupToHtmlCrossref) [../test/rdoc/test_rdoc_markup_to_html_crossref.rb:87]:
    Expected "

    <a href="../files/__/test/rdoc/rdoc_markup_to_html_crossref_reference_rb.html">../test/rdoc/rdoc_markup_to_html_crossref_reference.rb

    ", not "

    ../test/rdoc/rdoc_markup_to_html_crossref_reference.rb

    ".

1 tests, 29 assertions, 1 failures, 0 errors, 0 skips

Assuming the test is correct.


Index: lib/rdoc/markup/to_html_crossref.rb

--- lib/rdoc/markup/to_html_crossref.rb (revision 22822)
+++ lib/rdoc/markup/to_html_crossref.rb (working copy)
@@ -66,5 +66,5 @@ class RDoc::Markup::ToHtmlCrossref < RDo
# one special character (period, slash, or
# underscore).

  •                  | [\/\w]+[_\/\.][\w\/\.]+
    
  •                  | (?:\.\.\/)*[-\/\w]+[_\/\.][-\w\/\.]+
    
                     # Things that have markup suppressed
    

--
Nobu Nakada

=end

Actions #7

Updated by drbrain (Eric Hodel) over 14 years ago

=begin
I have applied Nobu's patch to RDoc trunk.
=end

Actions #8

Updated by marcandre (Marc-Andre Lafortune) over 14 years ago

  • Status changed from Open to Assigned
  • Target version set to 1.9.2

=begin

=end

Actions #9

Updated by naruse (Yui NARUSE) about 14 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

=begin
This issue was solved with changeset r26386.
Kazuhiro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0Like0