Project

General

Profile

Feature #15123

Enumerable#compact proposal

Added by printercu (Max Melentiev) about 1 year ago. Updated 22 days ago.

Status:
Feedback
Priority:
Normal
Target version:
-
[ruby-core:89017]

Description

Hi!

While Enumerable does not provide #compact method, it requires changing code in some cases to substitute array with enumerator.

For example, to reduce memory usage it's usual to change large_array.map { to_heavy_object }.chained_methods to large_array.lazy.... However if chained_methods contains compact, this change will fail. Replacing compact with reject(&:nil?) fixes it.

What do you think about adding #compact to Enumerable?

History

Updated by greggzst (Grzegorz Jakubiak) about 1 year ago

I'm in favor of this proposal. It simplifies working with large and small collections so one doesn't have to remember that can't use #compact when enumerator is returned and have to fall back to #reject(:nil?).

Updated by marcandre (Marc-Andre Lafortune) about 1 year ago

  • Assignee set to matz (Yukihiro Matsumoto)

Proposal seems acceptable to me.

Just to be clear: I imagine that Lazy#compact would still be lazy. Also compact is roughly select(&:itself), not reject(&:nil?) which would wrongly keep false.

Updated by Eregon (Benoit Daloze) about 1 year ago

marcandre (Marc-Andre Lafortune) wrote:

Also compact is roughly select(&:itself), not reject(&:nil?) which would wrongly keep false.

No, #compact only removes nil: ["a" ,false ,nil].compact => ["a", false].

Updated by shevegen (Robert A. Heiler) about 1 year ago

I think if the meaning is consistent (e. g. .compact meaning to eliminate
nil values from a given collection) then this seems ok. Perhaps this could
be added for the next developer meeting.

Updated by marcandre (Marc-Andre Lafortune) about 1 year ago

Eregon (Benoit Daloze) wrote:

No, #compact only removes nil: ["a" ,false ,nil].compact => ["a", false].

Lol, ouch, not sure how I could be so confused when I wrote that, sorry!

#6

Updated by nobu (Nobuyoshi Nakada) about 1 year ago

  • Backport deleted (2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN)
  • Tracker changed from Bug to Feature

Updated by shyouhei (Shyouhei Urabe) 6 months ago

Just leaving a comment that I wanted this method in my pet project just now. So +1.

Updated by matz (Yukihiro Matsumoto) 3 months ago

I don't see enough demand for compact where we have reject(&:nil?). Any additional use-case?

Matz.

#9

Updated by ko1 (Koichi Sasada) about 1 month ago

  • Status changed from Open to Feedback

Updated by baweaver (Brandon Weaver) 22 days ago

matz (Yukihiro Matsumoto): Its presence in Array and Hash make it more of a common interface that I could see being defined for Enumerable in general, though the immediate usecases are around Lazy. As mentioned above, sometimes one wants to use Enumerators directly or returns one from an Enumerable method which can cause some conflicts of available methods.

I believe it could be considered surprising that compact does not necessarily work with all collection-like types.

Also available in: Atom PDF