Misc #20032: Propose @kjtsanaktsidis as a commiter

• Status: Closed
• Assignee: hsbt (Hiroshi SHIBATA)

[jeremyevans0 (Jeremy Evans)]

I'd like to propose @kjtsanaktsidis (KJ Tsanaktsidis) as a committer, with a focus on bug triaging and fixing. During RubyKaigi 2023, KJ expressed interest in helping triage and fix bugs, and since then, he has fixed numerous bugs. What's most impressive about KJ's contributions is the difficulty of the bugs he has fixed, and the wide range of areas in which he has fixed bugs (GC, threading, FreeBSD support, ractors, rubygems, extensions, tests, old bugs, etc.).

Here is a list of bugs KJ has fixed:

• #20021
• #19994
• #19928
• #19873
• #19387
• #19680
• #4173

Here is a list of open pull requests submitted by KJ to fix bugs:

• #20022 https://github.com/ruby/ruby/pull/9041
• #19991 https://github.com/ruby/ruby/pull/8949 and https://github.com/ruby/ruby/pull/8856
• #20001 https://github.com/ruby/ruby/pull/8903
• #19717 https://github.com/ruby/ruby/pull/8331
• #19144 https://github.com/ruby/ruby/pull/7295
• #18795 https://github.com/ruby/ruby/pull/5992

In addition to these Redmine issues, KJ has also fixed other bugs:

• https://github.com/ruby/ruby/commit/9a62fd3cbae2ebb60e2f9cad782af1ad18db4319
• https://github.com/ruby/ruby/commit/76dc327eeffefe02577999fe5f8215f762a581b6
• https://github.com/ruby/ruby/commit/082962e857833dfc16881cb4dfb44caa175590ba
• https://github.com/ruby/ruby/commit/edee9b6a12ac846d7b3de2d704e170bf28178cb3
• https://github.com/ruby/ruby/commit/dd406c5a911d2f4a16ce97016666760713540185
• https://github.com/ruby/ruby/commit/7bd7aee02e303de27d2cddfc5ef47e612d6782cb
• https://github.com/ruby/ruby/commit/05ffc037ad15560cb2c683682c5bc374156571d7
• https://github.com/ruby/ruby/pull/7867
• https://github.com/ruby/ruby/pull/7865
• https://github.com/ruby/zlib/commit/3b9fe962d8
• https://github.com/ruby/zlib/commit/c96e8b9a57

In addition to bug fixing, KJ has also proposed and implemented a useful Socket feature:

• #19179 https://github.com/ruby/ruby/pull/6822

[tenderlovemaking (Aaron Patterson)]

+1

[byroot (Jean Boussier)]

+1

[kjtsanaktsidis (KJ Tsanaktsidis)]

Thank you for your nomination! I very much appreciate it, it's a real privilege. It's been great fun being part of the Ruby community, and I look forward to working even more closely with you all on Ruby if accepted as a committer.

[k0kubun (Takashi Kokubun)]

+1

[mame (Yusuke Endoh)]

Agreed. He is a great hacker who can write patches for very difficult areas and has the ownership to follow up on issues that arise after the merge.

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Assigned
• Assignee set to matz (Yukihiro Matsumoto)

[matz (Yukihiro Matsumoto)]

Agreed.

Matz.

[hsbt (Hiroshi SHIBATA)]

• Assignee changed from matz (Yukihiro Matsumoto) to hsbt (Hiroshi SHIBATA)

@kjtsanaktsidis (KJ Tsanaktsidis) Can you look https://github.com/ruby/ruby/wiki/Committer-How-To#how-to-register-you-as-a-committer and send required information to me?

[kjtsanaktsidis (KJ Tsanaktsidis)]

@hsbt (Hiroshi SHIBATA) done, thank you.

[hsbt (Hiroshi SHIBATA)]

I've finished to setup your account.

If you have any issues, please let me know.

[kjtsanaktsidis (KJ Tsanaktsidis)]

• Status changed from Assigned to Closed

Everything looks to be working great, thank you for getting it all set up.

[hsbt (Hiroshi SHIBATA)]

I received revoke request for his commit permission from himself. Because he doesn't have enough time for developing Ruby now.

@kjtsanaktsidis (KJ Tsanaktsidis) If you find any mistakes please comment and I'll always be happy to reinstate the permissions if you wish.

[kjtsanaktsidis (KJ Tsanaktsidis)]

Thanks @hsbt (Hiroshi SHIBATA) - yeah my current job has no Ruby at all and I haven’t committed in quite a while, so giving up access seems like the responsible thing to do from a security perspective.

I hope I get a bit more time in the future for Ruby, and would like to start contributing again when I can!

[hsbt (Hiroshi SHIBATA)]

Thanks for your reply. I revoked now.

https://github.com/ruby/git.ruby-lang.org/pull/102

And I keep your email or something without account permission.