Bug #5199

ext/tk: RB_GC_GUARD seems to be needed in several places

Added by Eric Wong over 2 years ago. Updated 3 months ago.

[ruby-core:39000]
Status:Closed
Priority:Normal
Assignee:Hidetoshi Nagai
Category:ext
Target version:2.1.0
ruby -v:ruby 1.9.4dev (2011-08-11 trunk 32931) [x86_64-linux] Backport:2.0.0: DONE

Description

I noticed the following in ext/tk/tkutil/tkutil.c:

rb_warning("fail to convert '%s' to string for Tk",
               RSTRING_PTR(rb_funcall(obj, rb_intern("inspect"), 0,
               0)));

id = rb_intern(RSTRING_PTR(rb_str_cat2(rb_str_new2("@"), str)));

I don't use or know the Tk ext at all, but the above examples do not
appear safe from a GC perspective. Compilers can optimize the original
VALUE away entirely so GC can collect.

RSTRING_PTR (being a macro,) may also evaluate its arguments multiple
times.

bug-5199-tkutil.diff Magnifier (3.83 KB) Nobuyoshi Nakada, 02/20/2013 12:54 PM

Associated revisions

Revision 41351
Added by Nobuyoshi Nakada 10 months ago

tkutil.c: prevent temporary objects from GC

  • ext/tk/tkutil/tkutil.c: use rbsprintf(), rbid2str(), and rbinternstr() instead of rbintern() and RSTRINGPTR() with RBGCGUARD(), to prevent temporary objects from GC. [Bug #5199]

History

#1 Updated by Kenta Murata over 2 years ago

  • Assignee set to Hidetoshi Nagai

#2 Updated by Shyouhei Urabe about 2 years ago

  • Status changed from Open to Assigned

#3 Updated by Koichi Sasada about 1 year ago

  • Target version changed from 2.0.0 to 2.1.0

Time up for 2.0.0.

Nagai-san, how about it?

#4 Updated by Hidetoshi Nagai about 1 year ago

From: "ko1 (Koichi Sasada)" redmine@ruby-lang.org
Subject: [ruby-trunk - Bug #5199] ext/tk: RBGCGUARD seems to be needed in several places
Date: Sun, 17 Feb 2013 19:06:43 +0900
Message-ID: redmine.journal-36417.20130217190643@ruby-lang.org

Issue #5199 has been updated by ko1 (Koichi Sasada).

Target version changed from 2.0.0 to 2.1.0

Time up for 2.0.0.

Nagai-san, how about it?

I'm very sorry. I didn't check the tickets about Ruby/Tk.
Last half year (and now), I was busy on my primary works.
So I couldn't follow up many changes for 2.0.0.
I'll fix them on 2.1.0 as soon as possible.
Although I'm sorry, it's not now. Maybe, it is one month or more after.
--
Hidetoshi NAGAI (nagai@ai.kyutech.ac.jp)
Department of Artificial Intelligence, Kyushu Institute of Technology

#5 Updated by Nobuyoshi Nakada about 1 year ago

Quick patch.

2.0 has GC safe functions, rbsprintf() with PRIsVALUE, rbintern_str(), and so on.

#6 Updated by Jon Forums about 1 year ago

nobu (Nobuyoshi Nakada) wrote:

Quick patch.

2.0 has GC safe functions, rbsprintf() with PRIsVALUE, rbintern_str(), and so on.

Does a list of these new 2.0 GC-safe functions exist anywhere?

If the 2.0 GC-safe functions aren't currently enumerated in a single, accessible place, should they be listed in a new section to README.EXT, and a short note added to mame-san's draft 2.0.0-p0 ANN? Perhaps under "Built-in libraries" as "New GC-safe API for more robust extensions."

#7 Updated by Hidetoshi Nagai 10 months ago

nobu (Nobuyoshi Nakada) wrote:

Quick patch.

2.0 has GC safe functions, rbsprintf() with PRIsVALUE, rbintern_str(), and so on.

Nakada-san, please commit the patch.

#8 Updated by Nobuyoshi Nakada 10 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r41351.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


tkutil.c: prevent temporary objects from GC

  • ext/tk/tkutil/tkutil.c: use rbsprintf(), rbid2str(), and rbinternstr() instead of rbintern() and RSTRINGPTR() with RBGCGUARD(), to prevent temporary objects from GC. [Bug #5199]

#9 Updated by Nobuyoshi Nakada 10 months ago

  • Backport set to 2.0.0: REQUIRED

#10 Updated by Tomoyuki Chikanaga 3 months ago

  • Backport changed from 2.0.0: REQUIRED to 2.0.0: DONE

r41351 was backported to ruby20_0 at r44564.

Also available in: Atom PDF