Project

General

Profile

Actions

Bug #5199

closed

ext/tk: RB_GC_GUARD seems to be needed in several places

Added by normalperson (Eric Wong) over 9 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
ruby 1.9.4dev (2011-08-11 trunk 32931) [x86_64-linux]
Backport:
[ruby-core:39000]

Description

I noticed the following in ext/tk/tkutil/tkutil.c:

rb_warning("fail to convert '%s' to string for Tk",
               RSTRING_PTR(rb_funcall(obj, rb_intern("inspect"), 0,
               0)));

id = rb_intern(RSTRING_PTR(rb_str_cat2(rb_str_new2("@"), str)));

I don't use or know the Tk ext at all, but the above examples do not
appear safe from a GC perspective. Compilers can optimize the original
VALUE away entirely so GC can collect.

RSTRING_PTR (being a macro,) may also evaluate its arguments multiple
times.


Files

bug-5199-tkutil.diff (3.83 KB) bug-5199-tkutil.diff nobu (Nobuyoshi Nakada), 02/20/2013 12:54 PM
Actions

Also available in: Atom PDF