Feature #9612: Gemify OpenSSL

• Status: Closed
• Assignee: rhenium (Kazuki Yamaguchi)
• Target version: -

[zzak (zzak _)]

Previously in #9439 we discussed removing OpenSSL from Ruby, however this wasn't the right approach.

I would like to suggest Aaron's approach from ruby-core:60075

You can see his patch here: https://github.com/tenderlove/ruby/commit/fd96a5b

As ruby-core:60063 states, we will need to modify the visibility of thread_native.h as seen here: https://github.com/ruby/ruby/blob/8cacc6459/ext/openssl/ossl.c#L469-L480

[shyouhei (Shyouhei Urabe)]

:+1: Great step.

[ko1 (Koichi Sasada)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

Applied in changeset r45944.

---

• ext/openssl/depend: remove dependency from internal headers.
  [Feature #9612]
• ext/openssl/ossl.c (ossl_fips_mode_set): ditto.
• ext/coverage/depend: ditto.
• include/ruby/thread_native.h: added.
  This header file only provides wrapper functions to control
  native threads. These wrapper functions are used by MRI
  implementation.
• vm_core.h: use include/ruby/thread_native.h.
• thread.c: ditto.
• thread_pthread.h: ditto.
• thread_win32.h: ditto.
• thread_native.h: removed.

[ko1 (Koichi Sasada)]

• Status changed from Closed to Open

Modified.

But current version doesn't work on 2.1.2 or before.

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset r45945.

---

openssl/depend: ossl.o

• ext/openssl/depend (ossl.o): now depends on thread_native.h
  under $(hdrdir) instead of $(top_srcdir). [Feature #9612]

[nobu (Nobuyoshi Nakada)]

• Status changed from Closed to Open

It might be better to create a subtask?

[zzak (zzak _)]

Awesome, thanks so much @ko1 (Koichi Sasada)!!!

We should consider this for 2.2.0, adding a gemspec with required_ruby_version to match.

[naruse (Yui NARUSE)]

• Related to Feature #5481: Gemifying Ruby standard library added

[headius (Charles Nutter)]

So will this be a default gem in 2.2? Has there been enough testing?

Because many Rubyists will now start putting "openssl" in their Gemfile, I think we need to get JRuby's version of openssl released as a -java platform gem.

I've started this process locally in the jruby/openssl fork of ruby/openssl. I hope we could work from one codebase in the future.

[naruse (Yui NARUSE)]

• Target version changed from 2.2.0 to 2.6

No, 2.2 doesn't include gemifying openssl.

[zzak (zzak _)]

• Assignee set to 7150

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Assigned
• Assignee changed from 7150 to rhenium (Kazuki Yamaguchi)

• Status changed from Assigned to Closed

Applied in changeset r56027.

---

import Ruby/OpenSSL 2.0.0.beta.1

• NEWS, {ext,test,sample}/openssl: Import Ruby/OpenSSL 2.0.0.beta.1.
  ext/openssl is now converted into a default gem. The full commit
  history since r55538 can be found at:
  https://github.com/ruby/openssl/compare/08e1881f5663...v2.0.0.beta.1
  [Feature #9612]