Ruby » Ruby master

Today

12:20 AM Revision 9d76a0ab (git): Add RB_GC_GUARD for ast_value

I think this change fixes the following assertion failure:
```
[BUG] unexpected rb_parser_ary_data_type (2114076960)... yui-knk (Kaneko Yuichiro)

06/29/2024

05:25 PM Revision a2c27bae (git): [YJIT] Don't expand kwargs on forwarding

Similarly to splat arrays, we shouldn't expand splat kwargs.
[ruby-core:118401] tenderlovemaking (Aaron Patterson)

03:48 PM Bug #20596: [BUG] unexpected rb_parser_ary_data_type (0) for script lines

Just saw the same in Puma CI: https://github.com/puma/puma/actions/runs/9725211941/job/26842252268?pr=3418#step:4:115 dentarg (Patrik Ragnarsson)

02:33 PM Revision 99306471 (git): Doc for Integer#ceil

burdettelamar (Burdette Lamar)

06/28/2024

08:04 PM Revision 291cc913 (git): [Bug #20598] Fix corruption of internal encoding string (#11069)

Fix corruption of internal encoding string
[Bug #20598]
Just like [Bug #20595], Encoding#name_list and Encoding#ali... peterzhu2118 (Peter Zhu)

05:44 PM Revision 3e14fe7c (git): YJIT: Fix `cargo doc --document-private-items` warnings [ci skip]

Mostly putting angle brackets around links to follow markdown syntax. alanwu (Alan Wu)

03:01 PM Revision bc91e8ff (git): YJIT: Move `ocb` parameters into `JITState`

Many functions take an outlined code block but do nothing more than
passing it along; only a couple of functions actu... alanwu (Alan Wu)

02:38 PM Revision 01f0dcd3 (git): Fix missing macOS version in Slack notifications

matrix.os is not set for some jobs. k0kubun (Takashi Kokubun)

02:12 PM Revision 98c923ff (git): Synchronize Bundler & RubyGems (#11071)

deivid (David Rodríguez)

02:11 PM Revision 1652c194 (git): Fix comment for VM_CALL_ARGS_SIMPLE (#11067)

* Set VM_CALL_KWARG flag first and reuse it to avoid checking kw_arg twice
* Fix comment for VM_CALL_ARGS_SIMPLE
* ... Gabriel Lacroix

10:49 AM Revision 5c826ebe (git): [rubygems/rubygems] Protect binstub access during creation with a flock

https://github.com/rubygems/rubygems/commit/88e3f1d23c deivid (David Rodríguez)

10:49 AM Revision 091a6ea8 (git): [rubygems/rubygems] Move flock logic to its own method

https://github.com/rubygems/rubygems/commit/91274128a8 deivid (David Rodríguez)

10:49 AM Revision f41a2c96 (git): [rubygems/rubygems] More compact `open_file` fallback on Windows

https://github.com/rubygems/rubygems/commit/8f34396af6 deivid (David Rodríguez)

07:33 AM Revision 5f837538 (git): [rubygems/rubygems] Avoid concurrent builds of Bundler when running specs

Instead, build it during setup when in CI.
This should avoid some Windows specific test failures when Bundler
copies... deivid (David Rodríguez)

06:52 AM Bug #20588 (Closed): RangeError: integer 132186463059104 too big to convert to 'int' since cdf33ed5f37f9649c482c3ba1d245f0d80ac01ce with YJIT enabled

byroot (Jean Boussier)

06/27/2024

11:58 PM Bug #20599 (Open): TypeError: #<BaseMailer:0x00000000008070> is not a symbol nor a string since 4cbc41d5e5cb6793174d5964975fdb4470323ca1 with YJIT enabled

https://buildkite.com/rails/rails-nightly/builds/711#01905b80-6b82-460c-908d-c8bc7e69293a/1213-1221
### Steps to... yahonda (Yasuo Honda)

11:52 PM Bug #20588: RangeError: integer 132186463059104 too big to convert to 'int' since cdf33ed5f37f9649c482c3ba1d245f0d80ac01ce with YJIT enabled

It looks like 4cbc41d5e5cb6793174d5964975fdb4470323ca1 addresses this issue.
```
$ RUBY_YJIT_ENABLE=1 bin/test te... yahonda (Yasuo Honda)

06:57 PM Bug #20598 (Closed): Corruption of internal encoding string

Applied in changeset commit:git|176c4bb3c7db87ca5b0486012cb6a005105448c5.
----------
Fix corruption of internal enco... peterzhu2118 (Peter Zhu)

06:06 PM Bug #20598 (Closed): Corruption of internal encoding string

GitHub PR: https://github.com/ruby/ruby/pull/11068
Just like #20595, Encoding#name_list and Encoding#aliases can h... peterzhu2118 (Peter Zhu)

06:06 PM Revision 176c4bb3 (git): Fix corruption of internal encoding string

[Bug #20598]
Just like [Bug #20595], Encoding#name_list and Encoding#aliases can have
their strings corrupted when E... peterzhu2118 (Peter Zhu)

04:00 PM Revision 9c5e9d29 (git): [ruby/openssl] rewriting most of the asn1 init code in ruby

to have as much of the lib in ruby as possible
https://github.com/ruby/openssl/commit/8305051728 chucke (Tiago Cardoso)

02:53 PM Bug #20597 (Open): `eval('break if false')` should raise SyntaxError but retuns nil

These are all SyntaxError (Invalid break, compile error (SyntaxError))
~~~ruby
ruby -ce "break if false"
ruby -ce ... tompng (tomoya ishida)

02:46 PM Revision 7a780a3e (git): [Bug #20595] Fix corruption of encoding name string (#11063)

Fix corruption of encoding name string
[Bug #20595]
enc_set_default_encoding will free the C string if the encoding... peterzhu2118 (Peter Zhu)

02:03 PM Bug #20596 (Open): [BUG] unexpected rb_parser_ary_data_type (0) for script lines

https://github.com/ruby/setup-ruby/actions/runs/9697443755/job/26761634004
```
/home/runner/.rubies/ruby-head/bin/b... Eregon (Benoit Daloze)

01:47 PM Bug #20595 (Closed): Corruption of encoding name string

Applied in changeset commit:git|c6a0d03649c686a537c1f513a1e32205ac6a6512.
----------
Fix corruption of encoding name... peterzhu2118 (Peter Zhu)

01:47 PM Revision c6a0d036 (git): Fix corruption of encoding name string

[Bug #20595]
enc_set_default_encoding will free the C string if the encoding is nil,
but the C string can be used by... peterzhu2118 (Peter Zhu)

01:44 PM Misc #20013: Travis CI status

As a note, by the Travis's above change, while people can run Travis by sending a pull-request to the ruby/* reposito... jaruga (Jun Aruga)

12:11 PM Misc #20013: Travis CI status

> I am working to get the list of the github accounts who contributed to the ruby/ruby, ruby/zlib and ruby/prism in t... jaruga (Jun Aruga)

12:53 PM Revision 815b345b (git): [rubygems/rubygems] Print a proper error when bin dir does not have writable permission bit

https://github.com/rubygems/rubygems/commit/979cd898f9 deivid (David Rodríguez)

12:53 PM Revision f88bb0e6 (git): [rubygems/rubygems] Reword some specs to disambiguate `chmod -x` from `chmod -w`

https://github.com/rubygems/rubygems/commit/2954ab79a9 deivid (David Rodríguez)

12:53 PM Revision d29a76b9 (git): [rubygems/rubygems] Only override `pre_install_checks` when necessary

RubyGems >= 3.5 no longer raises `Gem::FilePermissionError` explicitly.
https://github.com/rubygems/rubygems/commit/... deivid (David Rodríguez)

02:44 AM Revision 0c7776a2 (git): [DOC] Fix a link in NEWS.md

znz (Kazuhiro NISHIYAMA)

06/26/2024

09:59 PM Misc #20574: DevMeeting-2024-07-11

* [Feature #19979] Allow methods to declare that they don't accept a block via `&nil`
* Based on the discussion in... ufuk (Ufuk Kayserilioglu)

09:54 PM Feature #19979: Allow methods to declare that they don't accept a block via `&nil`

The result of the discussion at the face to face dev meeting in Naha was that while #15554 is preferred, it has some ... ufuk (Ufuk Kayserilioglu)

08:46 PM Revision ce7299d0 (git): [ruby/prism] Handle block exits under modifiers

https://github.com/ruby/prism/commit/6b78f5309b kddnewton (Kevin Newton)

08:25 PM Bug #20595: Corruption of encoding name string

The Ruby 3.3 backport PR is here: https://github.com/ruby/ruby/pull/11063 peterzhu2118 (Peter Zhu)

08:18 PM Bug #20595 (Closed): Corruption of encoding name string

GitHub PR: https://github.com/ruby/ruby/pull/11062
enc_set_default_encoding will free the C string if the encoding... peterzhu2118 (Peter Zhu)

08:01 PM Revision 4cbc41d5 (git): [YJIT] Fix block and splat handling when forwarding

This commit fixes splat and block handling when calling in to a
forwarding iseq. In the case of a splat we need to a... tenderlovemaking (Aaron Patterson)

05:31 PM Revision 43d7db38 (git): [DOC] Doc for exceptions (#11008)

burdettelamar (Burdette Lamar)

04:11 PM Revision 403413e1 (git): [rubygems/rubygems] Don't print warning about nil versions being discouraged during tests

https://github.com/rubygems/rubygems/commit/39a47c264e deivid (David Rodríguez)

03:51 PM Feature #20594: A new String method to append bytes while preserving encoding

> I consulted @maximecb (Maxime Chevalier-Boisvert) about this proposal, and according to her, accepting variable arg... maximecb (Maxime Chevalier-Boisvert)

01:39 PM Revision aa2a88ce (git): Use `File.open` instead of `IO.sysopen` (backport to 3.5) (#11061)

Use backport to 3.5 soutaro (Soutaro Matsumoto)

11:24 AM Revision c6c817df (git): [rubygems/rubygems] Add --no-test, --no-ci, and --no-linter options

https://github.com/rubygems/rubygems/commit/f58660ffcc jeromedalbert (Jerome Dalbert)

10:01 AM Revision 04c86a63 (git): [ruby/date] Update zonetab.h at 2024-06-26

https://github.com/ruby/date/commit/ef5a0dac5b nobu (Nobuyoshi Nakada)

05:45 AM Revision b4503d79 (git): Mentioned new mswin tasks related with vcpkg

hsbt (Hiroshi SHIBATA)

05:45 AM Revision 514aa805 (git): Added git for requirements of Windows build

hsbt (Hiroshi SHIBATA)

04:55 AM Revision f63b54ca (git): Update bundled gems list as of 2024-06-26

git[bot]

04:42 AM Revision da01974e (git): Test rbs-gem with unreleased version (#11060)

Use rbs#1912 soutaro (Soutaro Matsumoto)

03:31 AM Revision d70057d4 (git): We couldn't use nmake before configure.bat

hsbt (Hiroshi SHIBATA)

03:31 AM Revision 797e1dfb (git): Link dll files on install-vcpkg tasks

hsbt (Hiroshi SHIBATA)

06/25/2024

10:48 PM Revision 4fb7e1b6 (git): Change `enum rb_parser_ary_data_type` default value to 1 for easy debug

We face `[BUG] unexpected rb_parser_ary_data_type (0) for script lines`
on master branch recently.
This commit change... yui-knk (Kaneko Yuichiro)

08:15 PM Revision a47c152a (git): [ruby/prism] Fix documentation comment in generated with templates files

Fix warning
```
/******************************************************************************/
^
warning: [dangling... andrykonchin (Andrew Konchin)

03:33 PM Feature #20594: A new String method to append bytes while preserving encoding

+1 from me.
I forgot that `String#concat` accepted integers.
Together with accepting variable arguments, it feels... Eregon (Benoit Daloze)

06:39 AM Feature #20594 (Open): A new String method to append bytes while preserving encoding

### Context
When working with binary protocols such as `protobuf` or `MessagePack`, you may often need to assemble... byroot (Jean Boussier)

02:32 PM Revision b88ac94e (git): [rubygems/rubygems] Only validate resolution info in Bundler

This commit switches out the full gemspec validation for a partial one
which only performs resolution related checks.... thomasmarshall (Thomas Marshall)

02:32 PM Revision 39951293 (git): [rubygems/rubygems] Add Specification#validate_for_resolution

This method validates only what is required for resolution, skipping any
irrelevant metadata validation. This will be... thomasmarshall (Thomas Marshall)

01:33 PM Revision 9f420e2b (git): [PRISM] Modules should also emit the CLASS event

kddnewton (Kevin Newton)

12:55 PM Revision bfb4272d (git): [rubygems/rubygems] Regenerate bundler docs for June 2024.

https://github.com/rubygems/rubygems/commit/72103ca1e8 retro (Josef Šimánek)

07:30 AM Revision 65b991bc (git): Allow ambiguosity of `return` line

nobu (Nobuyoshi Nakada)

07:14 AM Revision 2f76faaf (git): Added tasks related vcpkg

hsbt (Hiroshi SHIBATA)

06:59 AM Revision 501b22aa (git): Update bundled gems list as of 2024-06-25

git[bot]

06:16 AM Misc #20574: DevMeeting-2024-07-11

* [Bug #20593] `Kernel#format` emits a `too many arguments for format string` warning when called with a single hash ... byroot (Jean Boussier)

03:42 AM Revision 3b4ff810 (git): Move to test/.excludes-prism

nobu (Nobuyoshi Nakada)

03:37 AM Revision a7f33c99 (git): Pending `EVENT_RETURN` settracefunc tests with Prism

nobu (Nobuyoshi Nakada)

02:50 AM Revision bed34b3a (git): Show the detail info in the first line

nobu (Nobuyoshi Nakada)

02:29 AM Feature #20564: Switch default parser to Prism

Is there the criteria for reverting this until Ruby 3.4 release? hsbt (Hiroshi SHIBATA)

02:08 AM Bug #20457 (Closed): Final `return` is eliminated from the AST

Applied in changeset commit:git|250fc1223c4dc293f8759ddedce9cba7841f1474.
----------
[Bug #20457] Do not remove fina... nobu (Nobuyoshi Nakada)

02:07 AM Revision 250fc122 (git): [Bug #20457] Do not remove final `return` node

This was an optimization for versions prior to 1.9 that traverse the
AST at runtime. nobu (Nobuyoshi Nakada)

02:07 AM Revision 22f98bb7 (git): Parenthesize `nd_fl_newline` macro expressions

nobu (Nobuyoshi Nakada)

12:55 AM Revision 691d85d3 (git): [ruby/reline] Rerender and enter raw mode again by SIGCONT

(https://github.com/ruby/reline/pull/727)
https://github.com/ruby/reline/commit/be45660c83 tompng (tomoya ishida)

06/24/2024

06:33 PM Bug #20043 (Closed): `defined?` checks for method existence but only sometimes

Applied in changeset commit:git|ae0c7faa79029ebe615487d23c8ee1ca44ce4a36.
----------
Handle hash and splat nodes in ... jeremyevans (Jeremy Evans)

06:32 PM Revision ae0c7faa (git): Handle hash and splat nodes in defined?

This supports the nodes in both in the parse.y and prism compilers.
Fixes [Bug #20043]
Co-authored-by: Kevin Newton... jeremyevans (Jeremy Evans)

03:38 PM Revision e428ee7b (git): [ruby/io-console] Use locale insensitive casecmp

https://github.com/ruby/io-console/commit/4b2e876dd7 nobu (Nobuyoshi Nakada)

03:38 PM Revision f4f8aa0f (git): [ruby/io-console] Use `strcasecmp`

https://github.com/ruby/io-console/commit/f8ec8a0617 nobu (Nobuyoshi Nakada)

03:38 PM Revision 25c2aa0a (git): [ruby/io-console] Use gperf 3.1 to generate ANSI-C code

https://github.com/ruby/io-console/commit/3798aae42d nobu (Nobuyoshi Nakada)

03:36 PM Revision 865a2027 (git): [ruby/date] Use locale insensitive casecmp

https://github.com/ruby/date/commit/cfbd6a6b13 nobu (Nobuyoshi Nakada)

03:36 PM Revision 7aafd3ed (git): [ruby/date] Use `strncasecmp`

https://github.com/ruby/date/commit/5974ac9c7e nobu (Nobuyoshi Nakada)

03:36 PM Revision 12e66f11 (git): [ruby/date] Use gperf 3.1 to generate ANSI-C code

https://github.com/ruby/date/commit/5d67437b1f nobu (Nobuyoshi Nakada)

02:43 PM Revision 1213623e (git): Use gperf 3.1 to generate ANSI-C code

nobu (Nobuyoshi Nakada)

02:15 PM Bug #20593: `Kernel#format` emits a `too many arguments for format string` warning when called with a single hash and no key is used

Proposed patch: https://github.com/ruby/ruby/pull/11053 byroot (Jean Boussier)

02:13 PM Bug #20593: `Kernel#format` emits a `too many arguments for format string` warning when called with a single hash and no key is used

Huh, interesting. I didn't realise it worked that way. I recently fixed a few of those in rubocop but didn't catch on... Earlopain (A S)

01:30 PM Bug #20593 (Open): `Kernel#format` emits a `too many arguments for format string` warning when called with a single hash and no key is used

`Kernel#format` emits a warning when too many arguments are passed.
It does so for postional arguments, which ma... byroot (Jean Boussier)

10:43 AM Revision 95ffcd3f (git): Fix `--debug-frozen-string-literal` to not apply `--disable-frozen-string-literal`

[Feature #20205]
This was an undesired side effect. Now that this value is a triplet, we can't
assume it's disabled ... byroot (Jean Boussier)

10:16 AM Bug #20588: RangeError: integer 132186463059104 too big to convert to 'int' since cdf33ed5f37f9649c482c3ba1d245f0d80ac01ce with YJIT enabled

I found a small repro for that last one:
```ruby
class Model
class << self
def scope(name, body, &block)
... byroot (Jean Boussier)

08:36 AM Bug #20588: RangeError: integer 132186463059104 too big to convert to 'int' since cdf33ed5f37f9649c482c3ba1d245f0d80ac01ce with YJIT enabled

Thanks for the update. The reason why I added another failure is to record which commit triggers the failure. No rush. yahonda (Yasuo Honda)

07:47 AM Bug #20588: RangeError: integer 132186463059104 too big to convert to 'int' since cdf33ed5f37f9649c482c3ba1d245f0d80ac01ce with YJIT enabled

There is also:
```
Assertion Failed: /usr/src/ruby/include/ruby/internal/core/rarray.h:257:rb_array_len:RB_TYPE_P... byroot (Jean Boussier)

07:30 AM Bug #20588: RangeError: integer 132186463059104 too big to convert to 'int' since cdf33ed5f37f9649c482c3ba1d245f0d80ac01ce with YJIT enabled

So that `proxy_controller_test` failure I can't repro locally it seems, but I see it actually crashed on another buil... byroot (Jean Boussier)

07:02 AM Bug #20588: RangeError: integer 132186463059104 too big to convert to 'int' since cdf33ed5f37f9649c482c3ba1d245f0d80ac01ce with YJIT enabled

I'll try to get the underlying error for that one.
@tenderlovemaking is looking at these issues, but he's at a com... byroot (Jean Boussier)

05:52 AM Bug #20588: RangeError: integer 132186463059104 too big to convert to 'int' since cdf33ed5f37f9649c482c3ba1d245f0d80ac01ce with YJIT enabled

There is another Rails CI failure https://buildkite.com/rails/rails-nightly/builds/683#01903773-e527-4777-8dd1-7656c1... yahonda (Yasuo Honda)

09:14 AM Revision 9cfc1362 (git): Extend the timeout of test_try_ldflag_invalid_opt and test_try_cppflag_invalid_opt

mame (Yusuke Endoh)

08:38 AM Revision 65d3eacc (git): No longer needs `sigsetjmp`

Since signal handlers just set flag and return now, `sigsetjmp` and
`siglongjmp` will not be needed. nobu (Nobuyoshi Nakada)

07:50 AM Revision 92f2cf1b (git): With ASAN `EC_REPUSH_TAG` doesn't work

With ASAN, `EC_TMPPOP_TAG`/`EC_REPUSH_TAG` doesn't work
so rewrite it without them. They are used for the performance... ko1 (Koichi Sasada)

04:25 AM Revision afd42e4d (git): Use $GITHUB_PATH

ono-max (Naoto Ono)

04:25 AM Revision a22448df (git): Integrate Launchable into mingw

ono-max (Naoto Ono)

04:18 AM Revision 96b45e61 (git): Introduce retry to the setup of test files with TestFile#test_stat

GitHub Actions macos-arm-oss is often too slow and does not timestamp as
expected. mame (Yusuke Endoh)

04:11 AM Revision ace17ba3 (git): Extend the timeout of Fiddle::TestFunction#test_nogvl_poll

mame (Yusuke Endoh)

02:54 AM Revision 3a323c6b (git): Extend the timeout of TestVMDump#test_darwin_invalid_call, etc.

mame (Yusuke Endoh)

01:48 AM Revision 2b5ddcee (git): Removed obsoleted workaround for OpenSSL

hsbt (Hiroshi SHIBATA)

01:48 AM Revision f58fef62 (git): Use expanded path for --with-opt-dir

hsbt (Hiroshi SHIBATA)

01:48 AM Revision 5f5da2e8 (git): Use manifest mode of vcpkg

hsbt (Hiroshi SHIBATA)

12:03 AM Revision 18404af9 (git): .github/actions/setup/macos/action.yml - use brew openssl@3, not 1.1

MSP-Greg (Greg L)